Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 645373005: Add documentation to the RendererConfig interface. (Closed)

Created:
6 years, 1 month ago by DaleCurtis
Modified:
6 years, 1 month ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo_config
Project:
chromium
Visibility:
Public.

Description

Add documentation to the RendererConfig interface. Whoops, forgot to add this before submitting the last patch. BUG=410451 TEST=none Committed: https://crrev.com/36c378b881b6a481294800ca1de5390a6136059d Cr-Commit-Position: refs/heads/master@{#301971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M media/mojo/services/renderer_config.h View 1 chunk +16 lines, -0 lines 0 comments Download
M media/mojo/services/renderer_config_default.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
DaleCurtis
Forgot to add these.
6 years, 1 month ago (2014-10-29 20:59:19 UTC) #2
xhwang
lgtm
6 years, 1 month ago (2014-10-29 21:17:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645373005/1
6 years, 1 month ago (2014-10-29 21:20:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/29653)
6 years, 1 month ago (2014-10-29 21:55:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645373005/1
6 years, 1 month ago (2014-10-29 22:50:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 23:16:32 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 23:17:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36c378b881b6a481294800ca1de5390a6136059d
Cr-Commit-Position: refs/heads/master@{#301971}

Powered by Google App Engine
This is Rietveld 408576698