Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: media/mojo/services/renderer_config_default.cc

Issue 645373005: Add documentation to the RendererConfig interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo_config
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/renderer_config.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/renderer_config_default.cc
diff --git a/media/mojo/services/renderer_config_default.cc b/media/mojo/services/renderer_config_default.cc
index ccae5905a4fa8889f384f41940a9f59d25fece91..0d7215ff154f93ea2a3fd1a71ae706de0217d8de 100644
--- a/media/mojo/services/renderer_config_default.cc
+++ b/media/mojo/services/renderer_config_default.cc
@@ -19,12 +19,19 @@ namespace internal {
class DefaultRendererConfig : public PlatformRendererConfig {
public:
DefaultRendererConfig() {
+ // TODO(dalecurtis): This will not work if the process is sandboxed...
if (!media::IsMediaLibraryInitialized()) {
base::FilePath module_dir;
CHECK(PathService::Get(base::DIR_EXE, &module_dir));
CHECK(media::InitializeMediaLibrary(module_dir));
}
+ // TODO(dalecurtis): We should find a single owner per process for the audio
+ // manager or make it a lazy instance. It's not safe to call Get()/Create()
+ // across multiple threads...
+ //
+ // TODO(dalecurtis): Eventually we'll want something other than a fake audio
+ // log factory here too. We should probably at least DVLOG() such info.
AudioManager* audio_manager = AudioManager::Get();
if (!audio_manager)
audio_manager = media::AudioManager::Create(&fake_audio_log_factory_);
« no previous file with comments | « media/mojo/services/renderer_config.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698