Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: media/mojo/services/renderer_config.h

Issue 645373005: Add documentation to the RendererConfig interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo_config
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/mojo/services/renderer_config_default.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/renderer_config.h
diff --git a/media/mojo/services/renderer_config.h b/media/mojo/services/renderer_config.h
index e64dd873a5b3ff02a8f72f7258587bfa21139a9b..409e79c58095af54d3ed5eb753c4943bebf128fc 100644
--- a/media/mojo/services/renderer_config.h
+++ b/media/mojo/services/renderer_config.h
@@ -15,21 +15,37 @@
namespace media {
+// Interface class which clients will extend to override (at compile time) the
+// default audio or video rendering configurations for MojoRendererService.
class PlatformRendererConfig {
public:
virtual ~PlatformRendererConfig() {};
+ // The list of audio decoders for use with the AudioRenderer. Ownership of
+ // the decoders is passed to the caller. The methods on each decoder will
+ // only be called on |media_task_runner|. |media_log_cb| should be used to
+ // log errors or important status information.
virtual ScopedVector<AudioDecoder> GetAudioDecoders(
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
const LogCB& media_log_cb) = 0;
+
+ // The audio output sink used for rendering audio.
virtual scoped_refptr<AudioRendererSink> GetAudioRendererSink() = 0;
+
+ // The platform's audio hardware configuration. Note, this must remain
+ // constant for the lifetime of the PlatformRendererConfig.
virtual const AudioHardwareConfig& GetAudioHardwareConfig() = 0;
+
+ // TODO(dalecurtis): Expose methods for retrieving the video decoders.
};
class RendererConfig {
public:
+ // Returns an instance of the RenderConfig object. Only one instance will
+ // exist per process.
static RendererConfig* Get();
+ // Copy of the PlatformRendererConfig interface.
ScopedVector<AudioDecoder> GetAudioDecoders(
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
const LogCB& media_log_cb);
« no previous file with comments | « no previous file | media/mojo/services/renderer_config_default.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698