Git footer fix for v8

Git footer fix for v8

Git footers doesn't seem to support v8, let alone know that trunk actually maps
to the candidate branch.  This should fix it.

BUG=
TBR=agable

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292445

[hinoka, 2014-10-10 21:32:55]

hinoka@chromium.org changed reviewers:
+ agable@chromium.org, machenbach@chromium.org

[hinoka, 2014-10-10 21:32:56]

Chrome perf bisect was relying on this working for V8, but apparently it wasn't.
 I believe this should fix it, along with add in new assumptions about the
candidate branch.

[Michael Achenbach, 2014-10-11 07:28:03]

Looks good - don't understand one thing - see comment:

https://codereview.chromium.org/645183002/diff/40001/git_footers.py
File git_footers.py (right):

https://codereview.chromium.org/645183002/diff/40001/git_footers.py#newcode97
git_footers.py:97: if re.match('.*/bleeding_edge.*$', match.group(1)):
What is this for? When would that match? What does it mean to return
refs/heads/?

[agable, 2014-10-13 08:37:15]

https://codereview.chromium.org/645183002/diff/40001/git_footers.py
File git_footers.py (right):

https://codereview.chromium.org/645183002/diff/40001/git_footers.py#newcode97
git_footers.py:97: if re.match('.*/bleeding_edge.*$', match.group(1)):
On 2014/10/11 07:28:02, Michael Achenbach wrote:
> What is this for? When would that match? What does it mean to return
> refs/heads/?

Agree, not sure what this is for. The stanzas up above look good, though.

[hinoka, 2014-10-13 17:26:07]

https://codereview.chromium.org/645183002/diff/40001/git_footers.py
File git_footers.py (right):

https://codereview.chromium.org/645183002/diff/40001/git_footers.py#newcode97
git_footers.py:97: if re.match('.*/bleeding_edge.*$', match.group(1)):
On 2014/10/13 08:37:15, agable wrote:
> On 2014/10/11 07:28:02, Michael Achenbach wrote:
> > What is this for? When would that match? What does it mean to return
> > refs/heads/?
> 
> Agree, not sure what this is for. The stanzas up above look good, though.

My bad, this wasn't supposed to be in here.

[hinoka, 2014-10-13 21:17:49]

TBRing to fix bisection bots.

[hinoka, 2014-10-13 21:17:53]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2014-10-13 21:18:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/645183002/110001

[commit-bot: I haz the power, 2014-10-13 21:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 21:20:35]

Presubmit check for 645183002-110001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
tests/checkout_test.py (81.12s) failed
Switched to branch 'master'
Already on 'master'
...............EE......
======================================================================
ERROR: testAutoProps (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 246, in setUp
    self.enabled = self.FAKE_REPOS.set_up_svn()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 305, in set_up_svn
    self.set_up()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
    self.cleanup_dirt()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 226, in cleanup_dirt
    if not self.tear_down_svn():
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 248, in tear_down_svn
    wait_for_port_to_free(self.host, self.svn_port)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
    assert False, '%d is still bound' % port
AssertionError: 10001 is still bound

======================================================================
ERROR: testException (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 246, in setUp
    self.enabled = self.FAKE_REPOS.set_up_svn()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 305, in set_up_svn
    self.set_up()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
    self.cleanup_dirt()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 226, in cleanup_dirt
    if not self.tear_down_svn():
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 248, in tear_down_svn
    wait_for_port_to_free(self.host, self.svn_port)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
    assert False, '%d is still bound' % port
AssertionError: 10001 is still bound

----------------------------------------------------------------------
Ran 23 tests in 80.874s

FAILED (errors=2)


Presubmit checks took 118.5s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[hinoka, 2014-10-13 21:23:22]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2014-10-13 21:23:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/645183002/110001

[commit-bot: I haz the power, 2014-10-13 21:25:52]

Committed patchset #3 (id:110001) as 292445

[Michael Achenbach, 2014-10-14 06:57:24]

lgtm - and thanks for working on this!