Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: git_footers.py

Issue 645183002: Git footer fix for v8 (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Remove extraneous stanza Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_footers.py
diff --git a/git_footers.py b/git_footers.py
index fe72e18a9f832da4d0b5a774bfd6e1d5c2fee243..f3b2482a08958abf41aad1331a7217d2da9ee5a0 100755
--- a/git_footers.py
+++ b/git_footers.py
@@ -81,6 +81,14 @@ def get_position(footers):
if svn_commit:
match = GIT_SVN_ID_PATTERN.match(svn_commit)
assert match, 'Invalid git-svn-id value: %s' % svn_commit
+ # V8 has different semantics than Chromium.
+ if re.match(r'.*https?://v8\.googlecode\.com/svn/trunk',
+ match.group(1)):
+ return ('refs/heads/candidates', match.group(2))
+ if re.match(r'.*https?://v8\.googlecode\.com/svn/branches/bleeding_edge',
+ match.group(1)):
+ return ('refs/heads/master', match.group(2))
+
# Assume that any trunk svn revision will match the commit-position
# semantics.
if re.match('.*/trunk.*$', match.group(1)):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698