Git footer fix for v8

git_footers.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import re
 import sys
 
 from collections import defaultdict
@@ skipping 63 matching lines @@
   position = get_unique(footers, 'Cr-Commit-Position')
   if position:
     match = CHROME_COMMIT_POSITION_PATTERN.match(position)
     assert match, 'Invalid Cr-Commit-Position value: %s' % position
     return (match.group(1), match.group(2))
 
   svn_commit = get_unique(footers, 'git-svn-id')
   if svn_commit:
     match = GIT_SVN_ID_PATTERN.match(svn_commit)
     assert match, 'Invalid git-svn-id value: %s' % svn_commit
+    # V8 has different semantics than Chromium.
+    if re.match(r'.*https?://v8\.googlecode\.com/svn/trunk',
+                match.group(1)):
+      return ('refs/heads/candidates', match.group(2))
+    if re.match(r'.*https?://v8\.googlecode\.com/svn/branches/bleeding_edge',
+                match.group(1)):
+      return ('refs/heads/master', match.group(2))
+
     # Assume that any trunk svn revision will match the commit-position
     # semantics.
     if re.match('.*/trunk.*$', match.group(1)):
       return ('refs/heads/master', match.group(2))
 
+    if re.match('.*/bleeding_edge.*$', match.group(1)):

[Michael Achenbach, 2014/10/11 07:28:02]

What is this for? When would that match? What does it mean to return
refs/heads/?

[agable, 2014/10/13 08:37:15]

Agree, not sure what this is for. The stanzas up above look good, though.

[hinoka, 2014/10/13 17:26:07]

My bad, this wasn't supposed to be in here.

+      return ('refs/heads/', match.group(2))
+
     # But for now only support faking branch-heads for chrome.
     branch_match = re.match('.*/chrome/branches/([\w/-]+)/src$', match.group(1))
     if branch_match:
       # svn commit numbers do not map to branches.
       return ('refs/branch-heads/%s' % branch_match.group(1), None)
 
   raise ValueError('Unable to infer commit position from footers')
 
 
 def main(args):
@@ skipping 29 matching lines @@
     assert pos[1], 'No valid position for commit'
     print pos[1]
   else:
     for k in footers.keys():
       for v in footers[k]:
         print '%s: %s' % (k, v)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))