Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 645093002: Revert of [Android] Add zip pushing and refine push mode selection. (Closed)

Created:
6 years, 2 months ago by jbudorick
Modified:
6 years, 2 months ago
CC:
chromium-reviews, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, klundberg+watch_chromium.org, bruening+watch_chromium.org, glider+watch_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add zip pushing and refine push mode selection. Broke telemetry_perf_unittests on Android Tests. TBR=craigdh@chromium.org,cjhopman@chromium.org,klundberg@chromium.org,tonyg@chromium.org NOTREECHECKS=true NOTRY=true BUG=400440 Committed: https://crrev.com/7eed7e0b28a56d5f18805cff73459115c4c31d5f Cr-Commit-Position: refs/heads/master@{#299133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -461 lines) Patch
M build/android/gyp/create_device_library_links.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/gyp/push_libraries.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/provision_devices.py View 1 chunk +1 line, -1 line 0 comments Download
D build/android/pylib/device/commands/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D build/android/pylib/device/commands/commands.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D build/android/pylib/device/commands/install_commands.py View 1 chunk +0 lines, -43 lines 0 comments Download
D build/android/pylib/device/commands/java/src/org/chromium/android/commands/unzip/Unzip.java View 1 chunk +0 lines, -94 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 14 chunks +91 lines, -159 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 4 chunks +122 lines, -113 lines 0 comments Download
M build/android/pylib/forwarder.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 2 chunks +6 lines, -9 lines 0 comments Download
M build/android/pylib/uiautomator/test_package.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/valgrind_tools.py View 1 chunk +3 lines, -3 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/java_apk.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645093002/1
6 years, 2 months ago (2014-10-10 17:18:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 17:19:42 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 17:20:22 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7eed7e0b28a56d5f18805cff73459115c4c31d5f
Cr-Commit-Position: refs/heads/master@{#299133}

Powered by Google App Engine
This is Rietveld 408576698