build/android/pylib/gtest/test_package_apk.py - Issue 645093002: Revert of [Android] Add zip pushing and refine push mode selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 645093002: Revert of [Android] Add zip pushing and refine push mode selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/test_package_apk.py

diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py

index f33b6086718e1e1c6af314f855dfe6342bf0a622..429cd2b073fd739d8f289016a9651d1c34d91227 100644

--- a/build/android/pylib/gtest/test_package_apk.py

+++ b/build/android/pylib/gtest/test_package_apk.py

@@ -44,9 +44,9 @@ class TestPackageApk(TestPackage):

# GTest expects argv[0] to be the executable path.

command_line_file.write(self.suite_name + ' ' + options)

command_line_file.flush()

- device.PushChangedFiles([(

+ device.PushChangedFiles(

command_line_file.name,

- self._package_info.cmdline_file)])

+ self._package_info.cmdline_file)

def _GetFifo(self):

# The test.fifo path is determined by:

« no previous file with comments | « build/android/pylib/forwarder.py ('k') | build/android/pylib/gtest/test_package_exe.py » ('j') | no next file with comments »