build/android/pylib/valgrind_tools.py - Issue 645093002: Revert of [Android] Add zip pushing and refine push mode selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/valgrind_tools.py

Issue 645093002: Revert of [Android] Add zip pushing and refine push mode selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/valgrind_tools.py

diff --git a/build/android/pylib/valgrind_tools.py b/build/android/pylib/valgrind_tools.py

index c63117280f2b722e09291292c194c2e276748d14..69f351a674c436248d5007e1246f99f27942c79f 100644

--- a/build/android/pylib/valgrind_tools.py

+++ b/build/android/pylib/valgrind_tools.py

@@ -172,10 +172,10 @@ class ValgrindTool(BaseTool):

'rm -r %s; mkdir %s' % (ValgrindTool.VGLOGS_DIR,

ValgrindTool.VGLOGS_DIR))

files = self.GetFilesForTool()

- self._device.PushChangedFiles(

- [((os.path.join(DIR_SOURCE_ROOT, f),

+ for f in files:

+ self._device.PushChangedFiles(

+ os.path.join(DIR_SOURCE_ROOT, f),

os.path.join(ValgrindTool.VG_DIR, os.path.basename(f)))

- for f in files)])

def SetupEnvironment(self):

"""Sets up device environment."""

« no previous file with comments | « build/android/pylib/uiautomator/test_package.py ('k') | build/apk_test.gypi » ('j') | no next file with comments »