Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 645073004: Remove FontRenderParams NOTIMPLEMENTED()s. (Closed)

Created:
6 years, 2 months ago by Daniel Erat
Modified:
6 years, 2 months ago
Reviewers:
msw, ckocagil, Matt Giuca
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Remove FontRenderParams NOTIMPLEMENTED()s. Don't spam the logs on Windows, Mac, or Android when GetFontRenderParams() is called with a non-empty query; RenderTextHarfBuzz sends non-empty queries and is being enabled for more platforms now. Continue to log an error if a family name is requested on these platforms, though. BUG=424971 Committed: https://crrev.com/1f6cb5cdf9edd7680c8bef6722482d090354627f Cr-Commit-Position: refs/heads/master@{#300339}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/gfx/font_render_params_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/font_render_params_mac.cc View 1 chunk +2 lines, -2 lines 2 comments Download
M ui/gfx/font_render_params_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Daniel Erat
6 years, 2 months ago (2014-10-20 14:04:17 UTC) #2
msw
lgtm with an optional nit https://codereview.chromium.org/645073004/diff/1/ui/gfx/font_render_params_mac.cc File ui/gfx/font_render_params_mac.cc (right): https://codereview.chromium.org/645073004/diff/1/ui/gfx/font_render_params_mac.cc#newcode33 ui/gfx/font_render_params_mac.cc:33: // TODO: Query the ...
6 years, 2 months ago (2014-10-20 18:30:18 UTC) #3
Daniel Erat
https://codereview.chromium.org/645073004/diff/1/ui/gfx/font_render_params_mac.cc File ui/gfx/font_render_params_mac.cc (right): https://codereview.chromium.org/645073004/diff/1/ui/gfx/font_render_params_mac.cc#newcode33 ui/gfx/font_render_params_mac.cc:33: // TODO: Query the OS for font render settings ...
6 years, 2 months ago (2014-10-20 20:00:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645073004/1
6 years, 2 months ago (2014-10-20 20:01:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 21:48:09 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 21:48:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f6cb5cdf9edd7680c8bef6722482d090354627f
Cr-Commit-Position: refs/heads/master@{#300339}

Powered by Google App Engine
This is Rietveld 408576698