Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ui/gfx/font_render_params_mac.cc

Issue 645073004: Remove FontRenderParams NOTIMPLEMENTED()s. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/font_render_params_android.cc ('k') | ui/gfx/font_render_params_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/font_render_params_mac.cc
diff --git a/ui/gfx/font_render_params_mac.cc b/ui/gfx/font_render_params_mac.cc
index 0062f3b1aae2fcdcbc3eb53d970449a74cdcbe9c..83fd341e507ae290ccb55c29b1dbc476ca08723b 100644
--- a/ui/gfx/font_render_params_mac.cc
+++ b/ui/gfx/font_render_params_mac.cc
@@ -28,9 +28,9 @@ FontRenderParams LoadDefaults() {
FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,
std::string* family_out) {
- // TODO: Query the OS for font render settings instead of returning defaults.
- if (!query.is_empty() || family_out)
+ if (family_out)
NOTIMPLEMENTED();
+ // TODO: Query the OS for font render settings instead of returning defaults.
msw 2014/10/20 18:30:18 optional nit: make this comment match the other tw
Daniel Erat 2014/10/20 20:00:47 i actually don't know the background here, or the
CR_DEFINE_STATIC_LOCAL(const gfx::FontRenderParams, params, (LoadDefaults()));
return params;
}
« no previous file with comments | « ui/gfx/font_render_params_android.cc ('k') | ui/gfx/font_render_params_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698