ui/gfx/font_render_params_win.cc - Issue 645073004: Remove FontRenderParams NOTIMPLEMENTED()s.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/font_render_params_win.cc

Issue 645073004: Remove FontRenderParams NOTIMPLEMENTED()s. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/font_render_params_win.cc

diff --git a/ui/gfx/font_render_params_win.cc b/ui/gfx/font_render_params_win.cc

index 372435d83f4e676685ab979edaad2185e4c18a36..70b19d2c292c1e6057b474121b44a51e989aa051 100644

--- a/ui/gfx/font_render_params_win.cc

+++ b/ui/gfx/font_render_params_win.cc

@@ -75,9 +75,9 @@ class CachedFontRenderParams : public gfx::SingletonHwnd::Observer {

FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,

std::string* family_out) {

- // Customized font rendering settings are not supported, only defaults.

- if (!query.is_empty() || family_out)

+ if (family_out)

NOTIMPLEMENTED();

+ // Customized font rendering settings are not supported, only defaults.

return CachedFontRenderParams::GetInstance()->GetParams(

query.for_web_contents);

}