Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 645023004: Disable OmniboxViewTest.Escape for all AURA since it is also broken for Linux dbg bulids. (Closed)

Created:
6 years, 2 months ago by miu
Modified:
6 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable OmniboxViewTest.Escape for all AURA since it is also broken for Linux dbg bulids. The test must be faulty, as I was able to confirm the browser exhibits the correct behavior in the same checkout/build on my desktop. BUG=158913 TBR=pkasting@chromium.org Committed: https://crrev.com/de428287a0c411b6c05f9428a0d00c40aee801f9 Cr-Commit-Position: refs/heads/master@{#300160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
miu
Disabling test. Not sure why this is broken on my desktop and not the tree. ...
6 years, 2 months ago (2014-10-17 20:13:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645023004/1
6 years, 2 months ago (2014-10-17 20:14:19 UTC) #3
Peter Kasting
LGTM
6 years, 2 months ago (2014-10-17 20:35:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 20:56:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/de428287a0c411b6c05f9428a0d00c40aee801f9 Cr-Commit-Position: refs/heads/master@{#300160}
6 years, 2 months ago (2014-10-17 20:57:45 UTC) #6
Mark P
miu: When I investigated all OmniboxViewTest tests about two months ago ( see https://codereview.chromium.org/517683002 ), ...
6 years, 2 months ago (2014-10-17 21:19:36 UTC) #7
miu
On 2014/10/17 21:19:36, Mark P wrote: > miu: When I investigated all OmniboxViewTest tests about ...
6 years, 2 months ago (2014-10-18 01:03:37 UTC) #8
miu
BTW--Following up on bug 158913...
6 years, 2 months ago (2014-10-18 01:21:32 UTC) #9
miu
6 years, 2 months ago (2014-10-18 01:54:45 UTC) #10
Message was sent while issue was closed.
On 2014/10/18 01:21:32, miu wrote:
> BTW--Following up on bug 158913...

I've RCR'ed most of the problem, and described findings in bug 158913.

Powered by Google App Engine
This is Rietveld 408576698