chrome/browser/ui/omnibox/omnibox_view_browsertest.cc - Issue 645023004: Disable OmniboxViewTest.Escape for all AURA since it is also broken for Linux dbg bulids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 645023004: Disable OmniboxViewTest.Escape for all AURA since it is also broken for Linux dbg bulids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

index eca9c5c642a6545697166fc9f4b4f1804ea7cf68..fa609f9d8faa2776ed7d0e8ecd7d91fc179f7685 100644

--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

@@ -539,7 +539,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, MAYBE_BackspaceInKeywordMode) {

}

// http://crbug.com/158913

-#if defined(OS_CHROMEOS) || defined(OS_WIN)

+#if defined(USE_AURA)

#define MAYBE_Escape DISABLED_Escape

#else

#define MAYBE_Escape Escape

« no previous file with comments | « no previous file | no next file » | no next file with comments »