Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 517683002: Re-Enable Most OmniboxViewTests (Closed)

Created:
6 years, 3 months ago by Mark P
Modified:
6 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, Maria
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-Enable Most OmniboxViewTests They were disabled because they flakily time out. Now with the switch to Aura, I don't see timeouts anymore. All the tests I enable in this changelist pass 10/10 on my machine. Trybots seem okay with it. BUG=131179, 165765 Committed: https://crrev.com/82e8b989227cdfa3501176491a06d156633199bc Cr-Commit-Position: refs/heads/master@{#292459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 7 chunks +11 lines, -33 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Mark P
mpearson@chromium.org changed reviewers: + msw@chromium.org
6 years, 3 months ago (2014-08-28 18:34:53 UTC) #1
Mark P
Other bugs will be followed-up with in later changelists. --mark
6 years, 3 months ago (2014-08-28 18:35:52 UTC) #2
Mark P
the implication being, please take a look :-)
6 years, 3 months ago (2014-08-28 18:41:08 UTC) #3
msw
LGTM, but BUG= looks wrong, use BUG=131179,165765 (+more?). Also, please take over or update 165765 ...
6 years, 3 months ago (2014-08-28 18:52:15 UTC) #4
Mark P
On 2014/08/28 18:52:15, msw wrote: > LGTM, but BUG= looks wrong, use BUG=131179,165765 (+more?). Good ...
6 years, 3 months ago (2014-08-28 18:54:39 UTC) #5
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 3 months ago (2014-08-28 19:55:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/517683002/1
6 years, 3 months ago (2014-08-28 19:57:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 33b1a2c002a624b61e3a4e93196b580f73ea0216
6 years, 3 months ago (2014-08-28 20:58:54 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82e8b989227cdfa3501176491a06d156633199bc
Cr-Commit-Position: refs/heads/master@{#292459}

Powered by Google App Engine
This is Rietveld 408576698