Source/core/css/parser/SizesCalcParser.cpp - Issue 644813005: Floating point MQs should not match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/SizesCalcParser.cpp

Issue 644813005: Floating point MQs should not match. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/SizesCalcParser.cpp

diff --git a/Source/core/css/parser/SizesCalcParser.cpp b/Source/core/css/parser/SizesCalcParser.cpp

index 7265554e0d10d5e55c05a9b51f9c6930bcb01b82..3c65f92dd81ded1e20c5481516c015dc6262a560 100644

--- a/Source/core/css/parser/SizesCalcParser.cpp

+++ b/Source/core/css/parser/SizesCalcParser.cpp

@@ -70,7 +70,7 @@ void SizesCalcParser::appendNumber(const MediaQueryToken& token)

bool SizesCalcParser::appendLength(const MediaQueryToken& token)

{

SizesCalcValue value;

- double result = 0;

+ float result = 0;

if (!m_mediaValues->computeLength(token.numericValue(), token.unitType(), result))

return false;

value.value = result;