Source/core/css/parser/SizesAttributeParser.cpp - Issue 644813005: Floating point MQs should not match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/SizesAttributeParser.cpp

Issue 644813005: Floating point MQs should not match. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/SizesAttributeParser.cpp

diff --git a/Source/core/css/parser/SizesAttributeParser.cpp b/Source/core/css/parser/SizesAttributeParser.cpp

index 9f6bcaa2c8e29a33188cb8e167b6bbc53d8f5cc5..7136a67a1952a409ddff0a00ecb66be9e6247667 100644

--- a/Source/core/css/parser/SizesAttributeParser.cpp

+++ b/Source/core/css/parser/SizesAttributeParser.cpp

@@ -35,7 +35,7 @@ bool SizesAttributeParser::calculateLengthInPixels(MediaQueryTokenIterator start

return false;

MediaQueryTokenType type = startToken->type();

if (type == DimensionToken) {

- double length;

+ float length;

if (!CSSPrimitiveValue::isLength(startToken->unitType()))

return false;

m_viewportDependant = CSSPrimitiveValue::isViewportPercentageLength(startToken->unitType());