Source/core/css/MediaValues.h - Issue 644813005: Floating point MQs should not match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaValues.h

Issue 644813005: Floating point MQs should not match. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaValues.h

diff --git a/Source/core/css/MediaValues.h b/Source/core/css/MediaValues.h

index 2a0b282f2993aaca109fd33d99fbe3e37741a971..27ab29e3e03a059235b92bdaf611ec7c12e99b23 100644

--- a/Source/core/css/MediaValues.h

+++ b/Source/core/css/MediaValues.h

@@ -41,7 +41,7 @@ public:

return true;

}

virtual bool computeLength(double value, CSSPrimitiveValue::UnitType, int& result) const = 0;

- virtual bool computeLength(double value, CSSPrimitiveValue::UnitType, double& result) const = 0;

+ virtual bool computeLength(double value, CSSPrimitiveValue::UnitType, float& result) const = 0;

rune 2014/10/10 09:01:46 Why did you start using floats instead of doubles?

virtual int viewportWidth() const = 0;

virtual int viewportHeight() const = 0;