Move the ShouldUseDirectWrite function from sandbox_win.cc/.h to ui/gfx/win/dpi.cc/.h.

Move the ShouldUseDirectWrite function from sandbox_win.cc/.h to ui/gfx/win/dpi.cc/.h.

This is in preparation for adding DirectWrite support for text rendering in the browser UI.

BUG=389649
Committed: https://crrev.com/8150ea60b7a77922ae6d7ae23cef630cfcc47b38
Cr-Commit-Position: refs/heads/master@{#299208}

[ananta, 2014-10-09 23:06:04]

ananta@chromium.org changed reviewers:
+ cpu@chromium.org, scottmg@chromium.org, sky@chromium.org

[ananta, 2014-10-09 23:06:05]

scottmg/cpu. Please look over everything.
sky: for ui

[scottmg, 2014-10-09 23:16:27]

Thanks for cleaning this up

https://codereview.chromium.org/644813004/diff/1/ui/gfx/switches.h
File ui/gfx/switches.h (right):

https://codereview.chromium.org/644813004/diff/1/ui/gfx/switches.h#newcode8
ui/gfx/switches.h:8: #include "base/compiler_specific.h"
nit; should probably just be build/build_config.h (for OS_WIN)

https://codereview.chromium.org/644813004/diff/1/ui/gfx/win/dpi.h
File ui/gfx/win/dpi.h (right):

https://codereview.chromium.org/644813004/diff/1/ui/gfx/win/dpi.h#newcode69
ui/gfx/win/dpi.h:69: GFX_EXPORT bool ShouldUseDirectWrite();
seems a bit odd to have it in dpi.{h,cc}?

[ananta, 2014-10-10 01:18:31]

https://codereview.chromium.org/644813004/diff/1/ui/gfx/win/dpi.h
File ui/gfx/win/dpi.h (right):

https://codereview.chromium.org/644813004/diff/1/ui/gfx/win/dpi.h#newcode69
ui/gfx/win/dpi.h:69: GFX_EXPORT bool ShouldUseDirectWrite();
On 2014/10/09 23:16:27, scottmg wrote:
> seems a bit odd to have it in dpi.{h,cc}?

will look into moving this a new file possibly

[ananta, 2014-10-10 18:45:36]

https://codereview.chromium.org/644813004/diff/1/ui/gfx/switches.h
File ui/gfx/switches.h (right):

https://codereview.chromium.org/644813004/diff/1/ui/gfx/switches.h#newcode8
ui/gfx/switches.h:8: #include "base/compiler_specific.h"
On 2014/10/09 23:16:27, scottmg wrote:
> nit; should probably just be build/build_config.h (for OS_WIN)

Done.

https://codereview.chromium.org/644813004/diff/1/ui/gfx/win/dpi.h
File ui/gfx/win/dpi.h (right):

https://codereview.chromium.org/644813004/diff/1/ui/gfx/win/dpi.h#newcode69
ui/gfx/win/dpi.h:69: GFX_EXPORT bool ShouldUseDirectWrite();
On 2014/10/10 01:18:31, ananta wrote:
> On 2014/10/09 23:16:27, scottmg wrote:
> > seems a bit odd to have it in dpi.{h,cc}?
> 
> will look into moving this a new file possibly

Moved to ui/gfx/win/direct_write.h/.cc

[scottmg, 2014-10-10 18:56:42]

lgtm

[sky, 2014-10-10 21:32:25]

LGTM when you fix the following and update any necessary gn files.

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write.cc
File ui/gfx/win/direct_write.cc (right):

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.cc:1: // Copyright (c) 2014 The Chromium Authors. All
rights reserved.
nit: same comment about no (c).

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.cc:6: #include "base/basictypes.h"
nit: newline between 5/6.

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.cc:14: 
nit: no newline.

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write.h
File ui/gfx/win/direct_write.h (right):

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.h:1: // Copyright (c) 2014 The Chromium Authors. All
rights reserved.
nit: no (c) on new files (see style guide).

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.h:11: 
nit: no newline.

[ananta, 2014-10-10 21:38:55]

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write.cc
File ui/gfx/win/direct_write.cc (right):

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.cc:1: // Copyright (c) 2014 The Chromium Authors. All
rights reserved.
On 2014/10/10 21:32:25, sky wrote:
> nit: same comment about no (c).

Done.

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.cc:6: #include "base/basictypes.h"
On 2014/10/10 21:32:25, sky wrote:
> nit: newline between 5/6.

Done.

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.cc:14: 
On 2014/10/10 21:32:25, sky wrote:
> nit: no newline.

Done.

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write.h
File ui/gfx/win/direct_write.h (right):

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.h:1: // Copyright (c) 2014 The Chromium Authors. All
rights reserved.
On 2014/10/10 21:32:25, sky wrote:
> nit: no (c) on new files (see style guide).

Done.

https://codereview.chromium.org/644813004/diff/430001/ui/gfx/win/direct_write...
ui/gfx/win/direct_write.h:11: 
On 2014/10/10 21:32:25, sky wrote:
> nit: no newline.

Done.

[ananta, 2014-10-10 21:40:04]

ananta@chromium.org changed reviewers:
+ piman@chromium.org

[ananta, 2014-10-10 21:40:17]

+piman for content OWNERS

[cpu_(ooo_6.6-7.5), 2014-10-10 21:43:21]

lgtm

[piman, 2014-10-10 21:53:24]

lgtm

[ananta, 2014-10-10 21:58:16]

The CQ bit was checked by ananta@chromium.org

[ananta, 2014-10-10 21:58:18]

The CQ bit was unchecked by ananta@chromium.org

[ananta, 2014-10-10 21:58:33]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-10-10 21:59:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644813004/490001

[commit-bot: I haz the power, 2014-10-10 22:58:07]

Committed patchset #6 (id:490001)

[commit-bot: I haz the power, 2014-10-10 22:59:56]

Patchset 6 (id:??) landed as
https://crrev.com/8150ea60b7a77922ae6d7ae23cef630cfcc47b38
Cr-Commit-Position: refs/heads/master@{#299208}