Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: content/renderer/renderer_main_platform_delegate_win.cc

Issue 644813004: Move the ShouldUseDirectWrite function from sandbox_win.cc/.h to ui/gfx/win/dpi.cc/.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments from sky Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/renderer_main_platform_delegate.h" 5 #include "content/renderer/renderer_main_platform_delegate.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
11 #include "base/win/scoped_comptr.h" 11 #include "base/win/scoped_comptr.h"
12 #include "base/win/win_util.h" 12 #include "base/win/win_util.h"
13 #include "base/win/windows_version.h" 13 #include "base/win/windows_version.h"
14 #include "content/common/sandbox_win.h"
15 #include "content/public/common/content_switches.h" 14 #include "content/public/common/content_switches.h"
16 #include "content/public/common/injection_test_win.h" 15 #include "content/public/common/injection_test_win.h"
17 #include "content/public/renderer/render_font_warmup_win.h" 16 #include "content/public/renderer/render_font_warmup_win.h"
18 #include "content/public/renderer/render_thread.h" 17 #include "content/public/renderer/render_thread.h"
19 #include "content/renderer/render_thread_impl.h" 18 #include "content/renderer/render_thread_impl.h"
20 #include "sandbox/win/src/sandbox.h" 19 #include "sandbox/win/src/sandbox.h"
21 #include "skia/ext/fontmgr_default_win.h" 20 #include "skia/ext/fontmgr_default_win.h"
22 #include "skia/ext/vector_platform_device_emf_win.h" 21 #include "skia/ext/vector_platform_device_emf_win.h"
23 #include "third_party/WebKit/public/web/WebRuntimeFeatures.h" 22 #include "third_party/WebKit/public/web/WebRuntimeFeatures.h"
24 #include "third_party/WebKit/public/web/win/WebFontRendering.h" 23 #include "third_party/WebKit/public/web/win/WebFontRendering.h"
25 #include "third_party/icu/source/i18n/unicode/timezone.h" 24 #include "third_party/icu/source/i18n/unicode/timezone.h"
26 #include "third_party/skia/include/ports/SkFontMgr.h" 25 #include "third_party/skia/include/ports/SkFontMgr.h"
27 #include "third_party/skia/include/ports/SkTypeface_win.h" 26 #include "third_party/skia/include/ports/SkTypeface_win.h"
27 #include "ui/gfx/win/direct_write.h"
28 #include "ui/gfx/win/dpi.h" 28 #include "ui/gfx/win/dpi.h"
29 29
30 #ifdef ENABLE_VTUNE_JIT_INTERFACE 30 #ifdef ENABLE_VTUNE_JIT_INTERFACE
31 #include "v8/src/third_party/vtune/v8-vtune.h" 31 #include "v8/src/third_party/vtune/v8-vtune.h"
32 #endif 32 #endif
33 33
34 #include <dwrite.h> 34 #include <dwrite.h>
35 35
36 namespace content { 36 namespace content {
37 namespace { 37 namespace {
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 #ifdef ENABLE_VTUNE_JIT_INTERFACE 82 #ifdef ENABLE_VTUNE_JIT_INTERFACE
83 if (command_line.HasSwitch(switches::kEnableVtune)) 83 if (command_line.HasSwitch(switches::kEnableVtune))
84 vTune::InitializeVtuneForV8(); 84 vTune::InitializeVtuneForV8();
85 #endif 85 #endif
86 86
87 // Be mindful of what resources you acquire here. They can be used by 87 // Be mindful of what resources you acquire here. They can be used by
88 // malicious code if the renderer gets compromised. 88 // malicious code if the renderer gets compromised.
89 bool no_sandbox = command_line.HasSwitch(switches::kNoSandbox); 89 bool no_sandbox = command_line.HasSwitch(switches::kNoSandbox);
90 90
91 bool use_direct_write = ShouldUseDirectWrite(); 91 bool use_direct_write = gfx::win::ShouldUseDirectWrite();
92 if (!no_sandbox) { 92 if (!no_sandbox) {
93 // ICU DateFormat class (used in base/time_format.cc) needs to get the 93 // ICU DateFormat class (used in base/time_format.cc) needs to get the
94 // Olson timezone ID by accessing the registry keys under 94 // Olson timezone ID by accessing the registry keys under
95 // HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones. 95 // HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones.
96 // After TimeZone::createDefault is called once here, the timezone ID is 96 // After TimeZone::createDefault is called once here, the timezone ID is
97 // cached and there's no more need to access the registry. If the sandbox 97 // cached and there's no more need to access the registry. If the sandbox
98 // is disabled, we don't have to make this dummy call. 98 // is disabled, we don't have to make this dummy call.
99 scoped_ptr<icu::TimeZone> zone(icu::TimeZone::createDefault()); 99 scoped_ptr<icu::TimeZone> zone(icu::TimeZone::createDefault());
100 100
101 if (use_direct_write) { 101 if (use_direct_write) {
(...skipping 26 matching lines...) Expand all
128 ::GetUserDefaultLangID(); 128 ::GetUserDefaultLangID();
129 ::GetUserDefaultLCID(); 129 ::GetUserDefaultLCID();
130 130
131 target_services->LowerToken(); 131 target_services->LowerToken();
132 return true; 132 return true;
133 } 133 }
134 return false; 134 return false;
135 } 135 }
136 136
137 } // namespace content 137 } // namespace content
OLDNEW
« no previous file with comments | « content/public/common/content_switches.cc ('k') | content/shell/renderer/layout_test/layout_test_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698