Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: content/common/sandbox_win.cc

Issue 644813004: Move the ShouldUseDirectWrite function from sandbox_win.cc/.h to ui/gfx/win/dpi.cc/.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments from sky Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/sandbox_win.h ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index 97071757abc33e58740185a2cfc0e343bf68d87f..9ac8c9f1759bd3952380a6d663c7a16232cc0eb7 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -12,7 +12,6 @@
#include "base/debug/trace_event.h"
#include "base/files/file_util.h"
#include "base/hash.h"
-#include "base/metrics/field_trial.h"
#include "base/path_service.h"
#include "base/process/launch.h"
#include "base/strings/string_util.h"
@@ -29,7 +28,7 @@
#include "sandbox/win/src/sandbox.h"
#include "sandbox/win/src/sandbox_nt_util.h"
#include "sandbox/win/src/win_utils.h"
-#include "ui/gfx/win/dpi.h"
+#include "ui/gfx/win/direct_write.h"
static sandbox::BrokerServices* g_broker_services = NULL;
static sandbox::TargetServices* g_target_services = NULL;
@@ -578,39 +577,6 @@ bool InitTargetServices(sandbox::TargetServices* target_services) {
return sandbox::SBOX_ALL_OK == result;
}
-bool ShouldUseDirectWrite() {
- // If the flag is currently on, and we're on Win7 or above, we enable
- // DirectWrite. Skia does not require the additions to DirectWrite in QFE
- // 2670838, but a simple 'better than XP' check is not enough.
- if (base::win::GetVersion() < base::win::VERSION_WIN7)
- return false;
-
- base::win::OSInfo::VersionNumber os_version =
- base::win::OSInfo::GetInstance()->version_number();
- if ((os_version.major == 6) && (os_version.minor == 1)) {
- // We can't use DirectWrite for pre-release versions of Windows 7.
- if (os_version.build < 7600)
- return false;
- }
-
- // If forced off, don't use it.
- const base::CommandLine& command_line =
- *base::CommandLine::ForCurrentProcess();
- if (command_line.HasSwitch(switches::kDisableDirectWrite))
- return false;
-
-#if !defined(NACL_WIN64)
- // Can't use GDI on HiDPI.
- if (gfx::GetDPIScale() > 1.0f)
- return true;
-#endif
-
- // Otherwise, check the field trial.
- const std::string group_name =
- base::FieldTrialList::FindFullName("DirectWrite");
- return group_name != "Disabled";
-}
-
base::ProcessHandle StartSandboxedProcess(
SandboxedProcessLauncherDelegate* delegate,
base::CommandLine* cmd_line) {
@@ -682,13 +648,15 @@ base::ProcessHandle StartSandboxedProcess(
return 0;
if (type_str == switches::kRendererProcess) {
- if (ShouldUseDirectWrite()) {
+#if !defined(NACL_WIN64)
+ if (gfx::win::ShouldUseDirectWrite()) {
AddDirectory(base::DIR_WINDOWS_FONTS,
NULL,
true,
sandbox::TargetPolicy::FILES_ALLOW_READONLY,
policy);
}
+#endif
} else {
// Hack for Google Desktop crash. Trick GD into not injecting its DLL into
// this subprocess. See
« no previous file with comments | « content/common/sandbox_win.h ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698