Issue 644433003: Type conversion fixes, tools/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 644433003: Type conversion fixes, tools/ edition. (Closed)

Created:
6 years, 2 months ago by Peter Kasting

Modified:
6 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Type conversion fixes, tools/ edition. This is mostly to fix MSVC warnings about possible value truncation. BUG=81439 TEST=none Committed: https://crrev.com/5c4699c224ba30bfb634f1a9d740e78706a46bdf Cr-Commit-Position: refs/heads/master@{#300131}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -4 lines)			Patch
M	tools/gn/command_gen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/filesystem_utils.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/generate_test_gn_data.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/trace.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644433003/1

6 years, 2 months ago (2014-10-17 18:12:48 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 18:18:09 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5c4699c224ba30bfb634f1a9d740e78706a46bdf
Cr-Commit-Position: refs/heads/master@{#300131}