tools/gn/filesystem_utils.cc - Issue 644433003: Type conversion fixes, tools/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/filesystem_utils.cc

Issue 644433003: Type conversion fixes, tools/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/filesystem_utils.cc

diff --git a/tools/gn/filesystem_utils.cc b/tools/gn/filesystem_utils.cc

index 56e472e7c8b88f1715129f5e7bbc059cb6056593..1e4194cab2c29a3594cdf14c0ac35310a0b429ea 100644

--- a/tools/gn/filesystem_utils.cc

+++ b/tools/gn/filesystem_utils.cc

@@ -132,7 +132,8 @@ std::vector<base::FilePath::StringType> GetPathComponents(

// don't want the slash in there. This doesn't support input like "C:foo"

// which means foo relative to the current directory of the C drive but

// that's basically legacy DOS behavior we don't need to support.

- if (result.size() >= 2 && result[1].size() == 1 && IsSlash(result[1][0]))

+ if (result.size() >= 2 && result[1].size() == 1 &&

+ IsSlash(static_cast<char>(result[1][0])))

result.erase(result.begin() + 1);

#endif

« no previous file with comments | « tools/gn/command_gen.cc ('k') | tools/gn/generate_test_gn_data.cc » ('j') | no next file with comments »