tools/gn/generate_test_gn_data.cc - Issue 644433003: Type conversion fixes, tools/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/generate_test_gn_data.cc

Issue 644433003: Type conversion fixes, tools/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/generate_test_gn_data.cc

diff --git a/tools/gn/generate_test_gn_data.cc b/tools/gn/generate_test_gn_data.cc

index 6489df40a8bc0477815046796fe0db7547ee32f1..05197f748d201f742db208151d5dd22883bdc785 100644

--- a/tools/gn/generate_test_gn_data.cc

+++ b/tools/gn/generate_test_gn_data.cc

@@ -38,7 +38,7 @@ base::FilePath RepoPathToPathName(const std::vector<int>& repo_path) {

std::string TargetIndexToLetter(int target_index) {

char ret[2];

- ret[0] = 'a' + target_index;

+ ret[0] = static_cast<char>('a' + target_index);

ret[1] = 0;

return ret;

}

« no previous file with comments | « tools/gn/filesystem_utils.cc ('k') | tools/gn/trace.cc » ('j') | no next file with comments »