Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 644093003: NOP refactor to make various layout tests use setTimeout 1 (Closed)

Created:
6 years, 2 months ago by alex clarke (OOO till 29th)
Modified:
6 years, 2 months ago
Reviewers:
alexclarke, eseidel
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, cbiesinger, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

NOP refactor to make various layout tests use setTimeout 1 This patch is a NOP because SetTimeout is clamped to 1ms under the hood. But according to the spec it's not supposed to be. The motivation behind this patch is fixing the tests that become flaky with https://codereview.chromium.org/467153003/ It's possible that not all setTimeout 0 -> 1s in the inspector tests are strictly necessary, as I've gone and changed them all in the affected files. BUG=402694 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -41 lines) Patch
M LayoutTests/css3/flexbox/repaint.html View 2 chunks +6 lines, -4 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-rtl-column.html View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/font-face-css-change-while-loading.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/events/scroll-event-raf-timing.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 4 chunks +7 lines, -5 lines 0 comments Download
M LayoutTests/inspector/tracing/resources/worker.js View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/resources/js-test.js View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/resources/run-after-display.js View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/svg/animations/reinserting-svg-into-document.html View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/svg/animations/smil-leak-element-instances.svg View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/svg/as-background-image/animated-svg-animation-control.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/js-late-gradient-creation.svg View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/js-late-marker-and-object-creation.svg View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/js-late-mask-and-object-creation.svg View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/js-late-pattern-creation.svg View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/pending-resource-after-removal.xhtml View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/resource-client-removal.svg View 1 chunk +6 lines, -4 lines 0 comments Download
M LayoutTests/svg/custom/use-detach.svg View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/svg/repaint/image-with-clip-path.svg View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
alexclarke
6 years, 2 months ago (2014-10-21 15:53:06 UTC) #3
eseidel
lgtm
6 years, 2 months ago (2014-10-21 16:23:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644093003/1
6 years, 2 months ago (2014-10-21 16:28:07 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:02:51 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184095

Powered by Google App Engine
This is Rietveld 408576698