LayoutTests/svg/custom/js-late-mask-and-object-creation.svg - Issue 644093003: NOP refactor to make various layout tests use setTimeout 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

Issue 644093003: NOP refactor to make various layout tests use setTimeout 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/custom/js-late-marker-and-object-creation.svg ('k') | LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

diff --git a/LayoutTests/svg/custom/js-late-mask-and-object-creation.svg b/LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

index 86a91c79ffe360b67d8c61d88366fcc271a7e849..36a0ac2ca67c909e36487b0b93c4b5ab59181eba 100644

--- a/LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

+++ b/LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

@@ -10,7 +10,8 @@

var content = document.getElementById("content");

function repaintTest() {

- setTimeout(createObject, 0);

+ // FIXME: we need a better way of waiting for layout/repainting to happen

+ setTimeout(createObject, 1);

}

function createObject()

@@ -23,7 +24,8 @@

rect.setAttribute("mask", "url(#dynMask)");

content.appendChild(rect);

- setTimeout(createMask, 0);

+ // FIXME: we need a better way of waiting for layout/repainting to happen

+ setTimeout(createMask, 1);

}

function createMask()