LayoutTests/svg/animations/reinserting-svg-into-document.html - Issue 644093003: NOP refactor to make various layout tests use setTimeout 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/animations/reinserting-svg-into-document.html

Issue 644093003: NOP refactor to make various layout tests use setTimeout 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/svg/animations/reinserting-svg-into-document.html

diff --git a/LayoutTests/svg/animations/reinserting-svg-into-document.html b/LayoutTests/svg/animations/reinserting-svg-into-document.html

index b0738ea2d13ba1cbe089cdb70b99df1bb3561ddb..e41c1fb6f9df22cdf42bb51cef92b7e5067b2d3d 100644

--- a/LayoutTests/svg/animations/reinserting-svg-into-document.html

+++ b/LayoutTests/svg/animations/reinserting-svg-into-document.html

@@ -11,12 +11,14 @@ function load() {

svg = document.getElementById("svg");

rect = document.getElementById("rect");

+ // FIXME: we need a better way of waiting for chromium events to happen

setTimeout(function () {

svg.setCurrentTime(1);

document.body.removeChild(svg);

document.body.appendChild(svg);

+ // FIXME: we need a better way of waiting for chromium events to happen

setTimeout(function () {

shouldBeCloseEnough("rect.x.animVal.value", "30", 1);

@@ -26,8 +28,8 @@ function load() {

if (window.testRunner)

testRunner.notifyDone();

- }, 0);

+ }, 1);

};

</script>

« no previous file with comments | « LayoutTests/resources/run-after-display.js ('k') | LayoutTests/svg/animations/smil-leak-element-instances.svg » ('j') | no next file with comments »