Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.h
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
index d93c66056b066185a791a05b480c694c21c5f00a..bec5ad5fbd47c741edaf0b318e8d78c93dec2358 100644
--- a/components/password_manager/core/browser/password_store.h
+++ b/components/password_manager/core/browser/password_store.h
@@ -51,6 +51,7 @@ class SyncableService;
namespace password_manager {
+class PasswordManagerClient;
class PasswordStoreConsumer;
class PasswordSyncableService;
@@ -127,9 +128,7 @@ class PasswordStore : protected PasswordStoreSync,
scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner);
// Reimplement this to add custom initialization. Always call this too.
- // |sync_username| is specified to aid in metrics reporting.
- virtual bool Init(const syncer::SyncableService::StartSyncFlare& flare,
- const std::string& sync_username);
+ virtual bool Init(const syncer::SyncableService::StartSyncFlare& flare);
// Adds the given PasswordForm to the secure password store asynchronously.
virtual void AddLogin(const autofill::PasswordForm& form);
@@ -170,8 +169,11 @@ class PasswordStore : protected PasswordStoreSync,
// consumer is destroyed.
virtual void GetBlacklistLogins(PasswordStoreConsumer* consumer);
- // Reports usage metrics for the database.
- virtual void ReportMetrics(const std::string& sync_username);
+ // Reports usage metrics for the database. |sync_username| and
+ // |custom_passphrase_sync_enabled| determine some of the UMA stats that
+ // may be reported.
+ virtual void ReportMetrics(const std::string& sync_username,
+ bool custom_passphrase_sync_enabled);
// Adds an observer to be notified when the password store data changes.
void AddObserver(Observer* observer);
@@ -205,7 +207,8 @@ class PasswordStore : protected PasswordStoreSync,
// Methods below will be run in PasswordStore's own thread.
// Synchronous implementation that reports usage metrics.
- virtual void ReportMetricsImpl(const std::string& sync_username) = 0;
+ virtual void ReportMetricsImpl(const std::string& sync_username,
+ bool custom_passphrase_sync_enabled) = 0;
// Bring PasswordStoreSync methods to the scope of PasswordStore. Otherwise,
// base::Bind can't be used with them because it fails to cast PasswordStore

Powered by Google App Engine
This is Rietveld 408576698