components/password_manager/core/browser/password_manager_unittest.cc - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_client.cc ('k') | components/password_manager/core/browser/password_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index 6b7a4808b6e1493e45105bb80faab918376351ce..4bb9f4adb48c47f1c95545156a6f1d64d43b8a05 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -96,8 +96,8 @@ class PasswordManagerTest : public testing::Test {

true);

store_ = new MockPasswordStore;

- EXPECT_CALL(*store_.get(), ReportMetrics(_)).Times(AnyNumber());

- CHECK(store_->Init(syncer::SyncableService::StartSyncFlare(), ""));

+ EXPECT_CALL(*store_.get(), ReportMetrics(_, _)).Times(AnyNumber());

+ CHECK(store_->Init(syncer::SyncableService::StartSyncFlare()));

EXPECT_CALL(client_, IsPasswordManagerEnabledForCurrentPage())

.WillRepeatedly(Return(true));