Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index d3a77b15094665ebf57cac5953e7333fdef5175e..a0620e2e5ddb09c7f40f0cd452d59d776f21b058 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -87,9 +87,7 @@ PasswordStore::PasswordStore(
observers_(new ObserverListThreadSafe<Observer>()),
shutdown_called_(false) {}
-bool PasswordStore::Init(const syncer::SyncableService::StartSyncFlare& flare,
- const std::string& sync_username) {
- ReportMetrics(sync_username);
+bool PasswordStore::Init(const syncer::SyncableService::StartSyncFlare& flare) {
#if defined(PASSWORD_MANAGER_ENABLE_SYNC)
ScheduleTask(base::Bind(&PasswordStore::InitSyncableService, this, flare));
#endif
@@ -174,9 +172,12 @@ void PasswordStore::GetBlacklistLogins(PasswordStoreConsumer* consumer) {
Schedule(&PasswordStore::GetBlacklistLoginsImpl, consumer);
}
-void PasswordStore::ReportMetrics(const std::string& sync_username) {
- ScheduleTask(base::Bind(&PasswordStore::ReportMetricsImpl, this,
- sync_username));
+void PasswordStore::ReportMetrics(const std::string& sync_username,
+ bool custom_passphrase_sync_enabled) {
+ ScheduleTask(base::Bind(&PasswordStore::ReportMetricsImpl,
+ this,
+ sync_username,
+ custom_passphrase_sync_enabled));
}
void PasswordStore::AddObserver(Observer* observer) {

Powered by Google App Engine
This is Rietveld 408576698