components/password_manager/core/browser/password_store_default.h - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.h

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store.cc ('k') | components/password_manager/core/browser/password_store_default.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default.h

diff --git a/components/password_manager/core/browser/password_store_default.h b/components/password_manager/core/browser/password_store_default.h

index 7dcf4fb4811e020d4d6b438931b1ac34c6383d80..7f42c192fd373401de4f33704211c8a71f0e4305 100644

--- a/components/password_manager/core/browser/password_store_default.h

+++ b/components/password_manager/core/browser/password_store_default.h

@@ -27,7 +27,8 @@ class PasswordStoreDefault : public PasswordStore {

~PasswordStoreDefault() override;

// Implements PasswordStore interface.

- void ReportMetricsImpl(const std::string& sync_username) override;

+ void ReportMetricsImpl(const std::string& sync_username,

+ bool custom_passphrase_sync_enabled) override;

PasswordStoreChangeList AddLoginImpl(

const autofill::PasswordForm& form) override;

PasswordStoreChangeList UpdateLoginImpl(