Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 643853004: mojo: Update PRESBUMIT.py (Closed)

Created:
6 years, 2 months ago by qsr
Modified:
6 years, 2 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Update PRESBUMIT.py - Update pylint to consider python bindings and python bindings tests. - Resolve pylint warnings. R=viettrungluu@chromium.org Committed: https://crrev.com/42868761b3c2c4a3bd5401142953e666f41093cc Cr-Commit-Position: refs/heads/master@{#299126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M mojo/PRESUBMIT.py View 2 chunks +12 lines, -1 line 0 comments Download
M mojo/public/python/mojo/bindings/descriptor.py View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/python/mojo/bindings/messaging.py View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/python/tests/async_wait_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/bindings_serialization_deserialization_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/python/tests/bindings_structs_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/messaging_unittest.py View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/python/tests/mojo_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/runloop_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/system_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
qsr
6 years, 2 months ago (2014-10-10 15:50:23 UTC) #1
viettrungluu
lgtm
6 years, 2 months ago (2014-10-10 15:54:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643853004/1
6 years, 2 months ago (2014-10-10 15:55:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 16:38:19 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 16:39:06 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/42868761b3c2c4a3bd5401142953e666f41093cc
Cr-Commit-Position: refs/heads/master@{#299126}

Powered by Google App Engine
This is Rietveld 408576698