Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: mojo/PRESUBMIT.py

Issue 643853004: mojo: Update PRESBUMIT.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/public/python/mojo/bindings/descriptor.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for mojo 5 """Presubmit script for mojo
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 import os.path 11 import os.path
12 12
13 def CheckChangeOnUpload(input_api, output_api): 13 def CheckChangeOnUpload(input_api, output_api):
14 # Additional python module paths (we're in src/mojo/); not everyone needs 14 # Additional python module paths (we're in src/mojo/); not everyone needs
15 # them, but it's easiest to add them to everyone's path. 15 # them, but it's easiest to add them to everyone's path.
16 # For ply and jinja2: 16 # For ply and jinja2:
17 third_party_path = os.path.join( 17 third_party_path = os.path.join(
18 input_api.PresubmitLocalPath(), "..", "third_party") 18 input_api.PresubmitLocalPath(), "..", "third_party")
19 # For the bindings generator: 19 # For the bindings generator:
20 mojo_public_bindings_pylib_path = os.path.join( 20 mojo_public_bindings_pylib_path = os.path.join(
21 input_api.PresubmitLocalPath(), "public", "tools", "bindings", "pylib") 21 input_api.PresubmitLocalPath(), "public", "tools", "bindings", "pylib")
22 # For the python bindings:
23 mojo_python_bindings_path = os.path.join(
24 input_api.PresubmitLocalPath(), "public", "python")
25 # For the python bindings tests:
26 mojo_python_bindings_tests_path = os.path.join(
27 input_api.PresubmitLocalPath(), "python", "tests")
22 # TODO(vtl): Don't lint these files until the (many) problems are fixed 28 # TODO(vtl): Don't lint these files until the (many) problems are fixed
23 # (possibly by deleting/rewriting some files). 29 # (possibly by deleting/rewriting some files).
24 temporary_black_list = input_api.DEFAULT_BLACK_LIST + \ 30 temporary_black_list = input_api.DEFAULT_BLACK_LIST + \
25 (r".*\bpublic[\\\/]tools[\\\/]bindings[\\\/]pylib[\\\/]mojom[\\\/]" 31 (r".*\bpublic[\\\/]tools[\\\/]bindings[\\\/]pylib[\\\/]mojom[\\\/]"
26 r"generate[\\\/].+\.py$", 32 r"generate[\\\/].+\.py$",
27 r".*\bpublic[\\\/]tools[\\\/]bindings[\\\/]generators[\\\/].+\.py$", 33 r".*\bpublic[\\\/]tools[\\\/]bindings[\\\/]generators[\\\/].+\.py$",
28 r".*\bspy[\\\/]ui[\\\/].+\.py$", 34 r".*\bspy[\\\/]ui[\\\/].+\.py$",
29 r".*\btools[\\\/]pylib[\\\/]transitive_hash\.py$", 35 r".*\btools[\\\/]pylib[\\\/]transitive_hash\.py$",
30 r".*\btools[\\\/]test_runner\.py$") 36 r".*\btools[\\\/]test_runner\.py$")
31 37
32 results = [] 38 results = []
33 pylint_extra_paths = [third_party_path, mojo_public_bindings_pylib_path] 39 pylint_extra_paths = [
40 third_party_path,
41 mojo_public_bindings_pylib_path,
42 mojo_python_bindings_path,
43 mojo_python_bindings_tests_path,
44 ]
34 results += input_api.canned_checks.RunPylint( 45 results += input_api.canned_checks.RunPylint(
35 input_api, output_api, extra_paths_list=pylint_extra_paths, 46 input_api, output_api, extra_paths_list=pylint_extra_paths,
36 black_list=temporary_black_list) 47 black_list=temporary_black_list)
37 return results 48 return results
OLDNEW
« no previous file with comments | « no previous file | mojo/public/python/mojo/bindings/descriptor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698