Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: mojo/PRESUBMIT.py

Issue 643853004: mojo: Update PRESBUMIT.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/python/mojo/bindings/descriptor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/PRESUBMIT.py
diff --git a/mojo/PRESUBMIT.py b/mojo/PRESUBMIT.py
index a7dc055b126d81c8e77e4c951e46808785bd54f3..41a8ec6ec332c7d6d1895dfef3914b2f3b3e6ebc 100644
--- a/mojo/PRESUBMIT.py
+++ b/mojo/PRESUBMIT.py
@@ -19,6 +19,12 @@ def CheckChangeOnUpload(input_api, output_api):
# For the bindings generator:
mojo_public_bindings_pylib_path = os.path.join(
input_api.PresubmitLocalPath(), "public", "tools", "bindings", "pylib")
+ # For the python bindings:
+ mojo_python_bindings_path = os.path.join(
+ input_api.PresubmitLocalPath(), "public", "python")
+ # For the python bindings tests:
+ mojo_python_bindings_tests_path = os.path.join(
+ input_api.PresubmitLocalPath(), "python", "tests")
# TODO(vtl): Don't lint these files until the (many) problems are fixed
# (possibly by deleting/rewriting some files).
temporary_black_list = input_api.DEFAULT_BLACK_LIST + \
@@ -30,7 +36,12 @@ def CheckChangeOnUpload(input_api, output_api):
r".*\btools[\\\/]test_runner\.py$")
results = []
- pylint_extra_paths = [third_party_path, mojo_public_bindings_pylib_path]
+ pylint_extra_paths = [
+ third_party_path,
+ mojo_public_bindings_pylib_path,
+ mojo_python_bindings_path,
+ mojo_python_bindings_tests_path,
+ ]
results += input_api.canned_checks.RunPylint(
input_api, output_api, extra_paths_list=pylint_extra_paths,
black_list=temporary_black_list)
« no previous file with comments | « no previous file | mojo/public/python/mojo/bindings/descriptor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698