Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/gn/builder_unittest.cc

Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/binary_target_generator.h ('k') | tools/gn/config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/builder_unittest.cc
diff --git a/tools/gn/builder_unittest.cc b/tools/gn/builder_unittest.cc
index 059037d7be946ee883c78a3c5604822351848516..7a2f6501bd4636e9144aac925064267652ed440d 100644
--- a/tools/gn/builder_unittest.cc
+++ b/tools/gn/builder_unittest.cc
@@ -17,18 +17,14 @@ class MockLoader : public Loader {
}
// Loader implementation:
- virtual void Load(const SourceFile& file,
- const LocationRange& origin,
- const Label& toolchain_name) override {
+ void Load(const SourceFile& file,
+ const LocationRange& origin,
+ const Label& toolchain_name) override {
files_.push_back(file);
}
- virtual void ToolchainLoaded(const Toolchain* toolchain) override {
- }
- virtual Label GetDefaultToolchain() const override {
- return Label();
- }
- virtual const Settings* GetToolchainSettings(
- const Label& label) const override {
+ void ToolchainLoaded(const Toolchain* toolchain) override {}
+ Label GetDefaultToolchain() const override { return Label(); }
+ const Settings* GetToolchainSettings(const Label& label) const override {
return NULL;
}
@@ -52,7 +48,7 @@ class MockLoader : public Loader {
}
private:
- virtual ~MockLoader() {}
+ ~MockLoader() override {}
std::vector<SourceFile> files_;
};
« no previous file with comments | « tools/gn/binary_target_generator.h ('k') | tools/gn/config.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698