Move forwardInputEvent to RemoteFrameClient.

Move forwardInputEvent to RemoteFrameClient.

This will eventually go away, but it doesn't belong on ChromeClient
in the meantime.

BUG=339659
TEST=No behavior change.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183839

[Charlie Reis, 2014-10-16 18:49:10]

creis@chromium.org changed reviewers:
+ japhet@chromium.org

[Charlie Reis, 2014-10-16 18:49:11]

Hey Nate-- here's a bit of cleanup, since I imagine it will take a while before
the browser side is ready.  I like the idea of sending more things through the
RemoteFrameClient interface.

[Nate Chapin, 2014-10-16 19:18:44]

LGTM, just a bunch of optional stylistic nitpicks

https://codereview.chromium.org/642823006/diff/20001/Source/core/frame/Remote...
File Source/core/frame/RemoteFrameClient.h (right):

https://codereview.chromium.org/642823006/diff/20001/Source/core/frame/Remote...
Source/core/frame/RemoteFrameClient.h:13: class Frame;
I wouldn't have thought this forward declaration would be necessary.

https://codereview.chromium.org/642823006/diff/20001/Source/core/html/HTMLFra...
File Source/core/html/HTMLFrameElementBase.cpp (left):

https://codereview.chromium.org/642823006/diff/20001/Source/core/html/HTMLFra...
Source/core/html/HTMLFrameElementBase.cpp:216:
contentFrame()->chromeClient().forwardInputEvent(toRemoteFrame(contentFrame()),
event);
Is there a ChromeClient.h include to remove along with this?

https://codereview.chromium.org/642823006/diff/20001/Source/web/RemoteFrameCl...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/642823006/diff/20001/Source/web/RemoteFrameCl...
Source/web/RemoteFrameClientImpl.cpp:92: // need to forward input events across
processes.
This comment doesn't add much, given that it lives in RemoteFrameClientImpl

https://codereview.chromium.org/642823006/diff/20001/Source/web/RemoteFrameCl...
Source/web/RemoteFrameClientImpl.cpp:107:
m_webFrame->client()->forwardInputEvent(&webEvent);
Would it be cleaner to define webEvent outside the if/else block, and do the
early exit and call to forwardInputEvent in only one place at the end?

[Charlie Reis, 2014-10-16 20:09:02]

Thanks!  Can you take another look at the webEvent syntax in
RemoteFrameClientImpl.cpp?  I'm a bit rusty on my Blink pointer syntax (e.g.,
OwnPtr), so it's worth double-checking.

https://codereview.chromium.org/642823006/diff/20001/Source/core/frame/Remote...
File Source/core/frame/RemoteFrameClient.h (right):

https://codereview.chromium.org/642823006/diff/20001/Source/core/frame/Remote...
Source/core/frame/RemoteFrameClient.h:13: class Frame;
On 2014/10/16 19:18:43, Nate Chapin wrote:
> I wouldn't have thought this forward declaration would be necessary.

Woops, put that one in when Frame was still in the forwardInputEvent contract. 
Removed.

https://codereview.chromium.org/642823006/diff/20001/Source/core/html/HTMLFra...
File Source/core/html/HTMLFrameElementBase.cpp (left):

https://codereview.chromium.org/642823006/diff/20001/Source/core/html/HTMLFra...
Source/core/html/HTMLFrameElementBase.cpp:216:
contentFrame()->chromeClient().forwardInputEvent(toRemoteFrame(contentFrame()),
event);
On 2014/10/16 19:18:43, Nate Chapin wrote:
> Is there a ChromeClient.h include to remove along with this?

Done.

https://codereview.chromium.org/642823006/diff/20001/Source/web/RemoteFrameCl...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/642823006/diff/20001/Source/web/RemoteFrameCl...
Source/web/RemoteFrameClientImpl.cpp:92: // need to forward input events across
processes.
On 2014/10/16 19:18:43, Nate Chapin wrote:
> This comment doesn't add much, given that it lives in RemoteFrameClientImpl

Actually, we likely will have RemoteFrames in default Chrome (at the top-level),
once we get remote-to-local swap and WindowProxy working.  I want to kill
swappedout:// as soon as we can.

https://codereview.chromium.org/642823006/diff/20001/Source/web/RemoteFrameCl...
Source/web/RemoteFrameClientImpl.cpp:107:
m_webFrame->client()->forwardInputEvent(&webEvent);
On 2014/10/16 19:18:43, Nate Chapin wrote:
> Would it be cleaner to define webEvent outside the if/else block, and do the
> early exit and call to forwardInputEvent in only one place at the end?

Done.

[Nate Chapin, 2014-10-16 20:14:46]

OwnPtr usage LGTM

https://codereview.chromium.org/642823006/diff/20001/Source/web/RemoteFrameCl...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/642823006/diff/20001/Source/web/RemoteFrameCl...
Source/web/RemoteFrameClientImpl.cpp:92: // need to forward input events across
processes.
On 2014/10/16 20:09:02, Charlie Reis wrote:
> On 2014/10/16 19:18:43, Nate Chapin wrote:
> > This comment doesn't add much, given that it lives in RemoteFrameClientImpl
> 
> Actually, we likely will have RemoteFrames in default Chrome (at the
top-level),
> once we get remote-to-local swap and WindowProxy working.  I want to kill
> swappedout:// as soon as we can.

Fair enough.

[Charlie Reis, 2014-10-16 20:15:35]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2014-10-16 20:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642823006/40001

[commit-bot: I haz the power, 2014-10-16 21:41:32]

Committed patchset #3 (id:40001) as 183839