Move forwardInputEvent to RemoteFrameClient.

Source/web/RemoteFrameClientImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "web/RemoteFrameClientImpl.h"
 
+#include "core/events/KeyboardEvent.h"
+#include "core/events/MouseEvent.h"
+#include "core/events/WheelEvent.h"
+#include "core/frame/RemoteFrame.h"
+#include "core/frame/RemoteFrameView.h"
+#include "core/rendering/RenderPart.h"
 #include "platform/exported/WrappedResourceRequest.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "platform/weborigin/SecurityPolicy.h"
+#include "web/WebInputEventConversion.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebRemoteFrameImpl.h"
 
 namespace blink {
 
 RemoteFrameClientImpl::RemoteFrameClientImpl(WebRemoteFrameImpl* webFrame)
     : m_webFrame(webFrame)
 {
 }
 
@@ skipping 49 matching lines @@
         m_webFrame->client()->postMessageEvent(WebLocalFrameImpl::fromFrame(sourceFrame), m_webFrame, WebSecurityOrigin(target), WebDOMMessageEvent(event));
     return true;
 }
 
 void RemoteFrameClientImpl::navigate(const ResourceRequest& request, bool shouldReplaceCurrentEntry)
 {
     if (m_webFrame->client())
         m_webFrame->client()->navigate(WrappedResourceRequest(request), shouldReplaceCurrentEntry);
 }
 
+// FIXME: Remove this code once we have input routing in the browser
+// process. See http://crbug.com/339659.
+void RemoteFrameClientImpl::forwardInputEvent(Event* event)
+{
+    // This is only called when we have out-of-process iframes, which
+    // need to forward input events across processes.

[Nate Chapin, 2014/10/16 19:18:43]

This comment doesn't add much, given that it lives in RemoteFrameClientImpl

[Charlie Reis, 2014/10/16 20:09:02]

Actually, we likely will have RemoteFrames in default Chrome (at the top-level),
once we get remote-to-local swap and WindowProxy working.  I want to kill
swappedout:// as soon as we can.

[Nate Chapin, 2014/10/16 20:14:45]

Fair enough.

+    // FIXME: Add a check for out-of-process iframes enabled.
+    if (event->isKeyboardEvent()) {
+        WebKeyboardEventBuilder webEvent(*static_cast<KeyboardEvent*>(event));
+        m_webFrame->client()->forwardInputEvent(&webEvent);
+    } else if (event->isMouseEvent()) {
+        WebMouseEventBuilder webEvent(m_webFrame->frame()->view(), toCoreFrame(m_webFrame)->ownerRenderer(), *static_cast<MouseEvent*>(event));
+        // Internal Blink events should not be forwarded.
+        if (webEvent.type == WebInputEvent::Undefined)
+            return;
+        m_webFrame->client()->forwardInputEvent(&webEvent);
+    } else if (event->isWheelEvent()) {
+        WebMouseWheelEventBuilder webEvent(m_webFrame->frame()->view(), toCoreFrame(m_webFrame)->ownerRenderer(), *static_cast<WheelEvent*>(event));
+        if (webEvent.type == WebInputEvent::Undefined)
+            return;
+        m_webFrame->client()->forwardInputEvent(&webEvent);

[Nate Chapin, 2014/10/16 19:18:43]

Would it be cleaner to define webEvent outside the if/else block, and do the
early exit and call to forwardInputEvent in only one place at the end?

[Charlie Reis, 2014/10/16 20:09:02]

Done.

+    }
+}
+
 } // namespace blink