Source/web/ChromeClientImpl.h - Issue 642823006: Move forwardInputEvent to RemoteFrameClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 642823006: Move forwardInputEvent to RemoteFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index dd5bed918b47b98ccb217e53c67a6ffb5ffe3ce7..119cd8245780ed34fcaadba250900d576de7f9df 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -173,10 +173,6 @@ public:

virtual void didEndEditingOnTextField(HTMLInputElement&) override;

virtual void handleKeyboardEventOnTextField(HTMLInputElement&, KeyboardEvent&) override;

- // FIXME: Remove this method once we have input routing in the browser

- // process. See http://crbug.com/339659.

- virtual void forwardInputEvent(RemoteFrame*, Event*) override;

virtual void didCancelCompositionOnSelectionChange() override;

virtual void willSetInputMethodState() override;

virtual void didUpdateTextOfFocusedElementByNonUserInput() override;

« no previous file with comments | « Source/core/page/ChromeClient.h ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »