Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 641733004: Merge FrameView and ScrollView. (Closed)

Created:
6 years, 2 months ago by skobes
Modified:
6 years, 2 months ago
CC:
aboxhall, darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, dmazzoni, dstockwell, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), mkwst+moarreviews_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rune+blink, shans, Steve Block, Timothy Loh, zoltan1
Project:
blink
Visibility:
Public.

Description

Merge FrameView and ScrollView. BUG=417774 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183555

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : Rebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1565 lines, -1673 lines) Patch
M Source/core/accessibility/AXObjectCache.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/accessibility/AXObjectCache.cpp View 5 chunks +4 lines, -4 lines 0 comments Download
M Source/core/accessibility/AXScrollView.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/accessibility/AXScrollView.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/accessibility/AXScrollbar.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 2 14 chunks +328 lines, -30 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 25 chunks +1164 lines, -27 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/AutoscrollController.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Theme.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/mac/ThemeMac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/mac/ThemeMac.mm View 1 2 15 chunks +22 lines, -22 lines 0 comments Download
D Source/platform/scroll/ScrollView.h View 1 2 1 chunk +0 lines, -356 lines 0 comments Download
D Source/platform/scroll/ScrollView.cpp View 1 2 1 chunk +0 lines, -1183 lines 0 comments Download
M Source/web/PopupListBox.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/ViewportAnchor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ViewportAnchor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebInputEventConversion.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebInputEventConversion.cpp View 5 chunks +4 lines, -5 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 5 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
skobes
This combines FrameView and ScrollView in the most mechanical way possible, to make it easy ...
6 years, 2 months ago (2014-10-09 18:13:35 UTC) #3
Ian Vollick
I love it! Thank you very much for just doing a braindead copy from ScrollView; ...
6 years, 2 months ago (2014-10-10 17:43:25 UTC) #4
skobes
https://codereview.chromium.org/641733004/diff/20001/Source/core/frame/FrameView.h File Source/core/frame/FrameView.h (right): https://codereview.chromium.org/641733004/diff/20001/Source/core/frame/FrameView.h#newcode481 Source/core/frame/FrameView.h:481: void setParentInternal(Widget*); // Overridden to update the overlapping scrollbar ...
6 years, 2 months ago (2014-10-10 17:54:27 UTC) #5
Nate Chapin
Source/web/ LGTM
6 years, 2 months ago (2014-10-10 20:02:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641733004/200001
6 years, 2 months ago (2014-10-10 20:09:11 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:43:46 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:200001) as 183555

Powered by Google App Engine
This is Rietveld 408576698