Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 64113006: Rename es => exceptionState in core/dom (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Rename es => exceptionState in core/dom Relanding large patch incrementally, via CQ: Rename es => exceptionState in other than bindings/ https://codereview.chromium.org/72363002/ cd "$BLINK_DIR/Source/core/dom" && \ sed -ri '/"es"/ ! s/\<es\>/exceptionState/g' \ $(git ls-files '*.cpp' '*.h') TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -558 lines) Patch
M Source/core/dom/Attr.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/CharacterData.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/Clipboard.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 17 chunks +44 lines, -44 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/DOMSettableTokenList.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/DOMStringMap.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/DOMTokenList.cpp View 5 chunks +19 lines, -19 lines 0 comments Download
M Source/core/dom/DOMURL.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/dom/DOMURL.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DataTransferItemList.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 32 chunks +100 lines, -100 lines 0 comments Download
M Source/core/dom/Element.cpp View 12 chunks +37 lines, -37 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/MutationObserver.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/dom/Node.cpp View 7 chunks +28 lines, -28 lines 0 comments Download
M Source/core/dom/NodeIterator.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Range.cpp View 48 chunks +215 lines, -215 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Text.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/TreeWalker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementException.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistry.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/64113006/1
7 years, 1 month ago (2013-11-15 10:43:23 UTC) #1
Nils Barth (inactive)
Breaking up core/ into 3+ CLs b/c ~200 files. Lotta changes in Document.cpp and Range.cpp, ...
7 years, 1 month ago (2013-11-15 10:43:43 UTC) #2
haraken
rubber-stamp LGTM
7 years, 1 month ago (2013-11-15 11:03:24 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-15 11:34:35 UTC) #4
Message was sent while issue was closed.
Change committed as 162108

Powered by Google App Engine
This is Rietveld 408576698