Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 72363002: Rename es => exceptionState in other than bindings/ (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
CC:
blink-reviews, shans, webcomponents-bugzilla_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, loislo+blink_chromium.org, Steve Block, rwlbuis, krit, caseq+blink_chromium.org, dino_apple.com, alancutter (OOO until 2018), pfeldman+blink_chromium.org, alecflett, Timothy Loh, abarth-chromium, aandrey+blink_chromium.org, dstockwell, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, bemjb+rendering_chromium.org, Eric Willigers, kenneth.christiansen, nessy, rjwright, zoltan1, philipj_slow, lushnikov+blink_chromium.org, Raymond Toy, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, paulirish+reviews_chromium.org, darktears, Nate Chapin, vcarbune.chromium, jsbell, eustas+blink_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), f(malita), groby+blinkspell_chromium.org, cmumford, dgrogan, Stephen Chennney, kouhei (in TOK)
Visibility:
Public.

Description

Rename es => exceptionState in other than bindings/ Mechanical renaming, via sed replace: cd "$BLINK_DIR/Source" && \ sed -ri 's/\<es\>/exceptionState/g' \ $(git grep -w es | grep -v '^bindings') AFAICT there are no uses of 'es' in URLs or documentation which are affected by this, unlike for bindings/, where there are links to Web IDL spec using 'es-...'. Followup to: Rename es => exceptionState in bindings/ https://codereview.chromium.org/68893018/ R=haraken@chromium.org TBR=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162050

Patch Set 1 #

Patch Set 2 : Retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3262 lines, -3262 lines) Patch
M Source/core/animation/AnimatableStrokeDasharrayListTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/CSSGroupingRule.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSMatrix.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 6 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/CSSStyleSheet.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/CSSVariablesMap.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFace.cpp View 1 2 chunks +30 lines, -30 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/MediaList.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/CharacterData.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/Clipboard.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 17 chunks +44 lines, -44 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/DOMSettableTokenList.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/DOMStringMap.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/DOMTokenList.cpp View 1 5 chunks +19 lines, -19 lines 0 comments Download
M Source/core/dom/DOMURL.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/dom/DOMURL.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DataTransferItemList.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 32 chunks +100 lines, -100 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 12 chunks +37 lines, -37 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 1 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 7 chunks +28 lines, -28 lines 0 comments Download
M Source/core/dom/NodeIterator.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 48 chunks +215 lines, -215 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Text.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/TreeWalker.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementException.cpp View 1 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistry.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/SplitTextNodeCommand.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/TextCheckingHelper.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 7 chunks +13 lines, -13 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/fileapi/FileError.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.cpp View 1 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 8 chunks +16 lines, -16 lines 0 comments Download
M Source/core/frame/DOMWindowBase64.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/frame/History.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/ImageBitmapTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/Location.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 9 chunks +50 lines, -50 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 8 chunks +37 lines, -37 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 10 chunks +30 lines, -30 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 6 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 1 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 7 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 9 chunks +15 lines, -15 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/MediaController.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/TimeRanges.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/canvas/CanvasGradient.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasPathMethods.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/canvas/CanvasPattern.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 15 chunks +84 lines, -84 lines 0 comments Download
M Source/core/html/canvas/DataView.cpp View 1 3 chunks +36 lines, -36 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 18 chunks +40 lines, -40 lines 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 5 chunks +16 lines, -16 lines 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/html/shadow/MediaControlsChromium.cpp View 1 1 chunk +21 lines, -21 lines 0 comments Download
M Source/core/html/shadow/MediaControlsChromiumAndroid.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 1 9 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/track/VTTRegion.cpp View 1 2 chunks +19 lines, -19 lines 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 1 8 chunks +84 lines, -84 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 13 chunks +21 lines, -21 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 14 chunks +65 lines, -65 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 7 chunks +28 lines, -28 lines 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 1 5 chunks +18 lines, -18 lines 0 comments Download
M Source/core/inspector/InspectorHistory.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorIndexedDBAgent.cpp View 1 9 chunks +34 lines, -34 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 14 chunks +54 lines, -54 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCache.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/page/DOMSelection.cpp View 1 10 chunks +28 lines, -28 lines 0 comments Download
M Source/core/page/EventSource.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/ChromiumDataObject.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/image-decoders/gif/GIFImageReader.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderQuote.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/storage/Storage.cpp View 1 1 chunk +28 lines, -28 lines 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAngle.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGAnimatedType.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGColor.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLength.h View 1 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 1 8 chunks +25 lines, -25 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 6 chunks +25 lines, -25 lines 0 comments Download
M Source/core/svg/SVGLengthList.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGMatrix.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPaint.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedEnumerationPropertyTearOff.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGListProperty.h View 1 15 chunks +44 lines, -44 lines 0 comments Download
M Source/core/svg/properties/SVGListPropertyTearOff.h View 1 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/properties/SVGPathSegListPropertyTearOff.h View 1 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/svg/properties/SVGPathSegListPropertyTearOff.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/properties/SVGStaticListPropertyTearOff.h View 1 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/properties/SVGTransformListPropertyTearOff.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 8 chunks +23 lines, -23 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 59 chunks +241 lines, -241 lines 0 comments Download
M Source/core/timing/Performance.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/timing/PerformanceUserTiming.cpp View 1 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/workers/AbstractWorker.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/workers/Worker.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xml/DOMParser.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/DocumentXPathEvaluator.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 23 chunks +61 lines, -61 lines 0 comments Download
M Source/core/xml/XMLSerializer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathEvaluator.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/xml/XPathExpression.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/xml/XPathParser.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xml/XPathResult.cpp View 1 6 chunks +19 lines, -19 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 6 chunks +12 lines, -12 lines 0 comments Download
M Source/devtools/front_end/Images/localStorage.png View 1 Binary file 0 comments Download
M Source/devtools/scripts/closure/compiler.jar View Binary file 0 comments Download
M Source/modules/crypto/Crypto.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/crypto/Key.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 1 8 chunks +51 lines, -51 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 1 4 chunks +28 lines, -28 lines 0 comments Download
M Source/modules/encoding/TextDecoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextDecoder.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/encoding/TextEncoder.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 1 5 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemSync.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/filesystem/DirectoryEntrySync.cpp View 1 1 chunk +9 lines, -9 lines 0 comments Download
M Source/modules/filesystem/DirectoryReaderSync.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/filesystem/EntrySync.cpp View 1 1 chunk +12 lines, -12 lines 0 comments Download
M Source/modules/filesystem/FileEntrySync.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/filesystem/FileWriter.cpp View 1 5 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/filesystem/FileWriterSync.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/filesystem/SyncCallbackHelper.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 3 chunks +44 lines, -44 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 1 7 chunks +36 lines, -36 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 6 chunks +23 lines, -23 lines 0 comments Download
M Source/modules/indexeddb/IDBFactory.cpp View 1 5 chunks +15 lines, -15 lines 0 comments Download
M Source/modules/indexeddb/IDBIndex.cpp View 1 5 chunks +36 lines, -36 lines 0 comments Download
M Source/modules/indexeddb/IDBKeyRange.cpp View 1 3 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 1 16 chunks +83 lines, -83 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 5 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 4 chunks +9 lines, -9 lines 0 comments Download
M Source/modules/mediasource/MediaSourceBase.cpp View 1 6 chunks +9 lines, -9 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 16 chunks +34 lines, -34 lines 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/modules/mediasource/WebKitSourceBuffer.cpp View 1 7 chunks +10 lines, -10 lines 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 1 3 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 1 4 chunks +21 lines, -21 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 1 15 chunks +71 lines, -71 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 8 chunks +16 lines, -16 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AnalyserNode.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/webaudio/AudioBasicInspectorNode.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioBuffer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 4 chunks +15 lines, -15 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 1 23 chunks +49 lines, -49 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 1 14 chunks +17 lines, -17 lines 0 comments Download
M Source/modules/webaudio/AudioScheduledSourceNode.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioScheduledSourceNode.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/DelayNode.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/DelayNode.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webaudio/WaveShaperNode.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/DatabaseSync.cpp View 1 5 chunks +23 lines, -23 lines 0 comments Download
M Source/modules/webdatabase/SQLResultSet.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLStatementSync.cpp View 1 5 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackendSync.cpp View 1 7 chunks +15 lines, -15 lines 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.cpp View 1 2 chunks +9 lines, -9 lines 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 10 chunks +43 lines, -43 lines 0 comments Download
M Source/platform/text/LocaleToScriptMapping.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/StorageAreaProxy.cpp View 1 1 chunk +16 lines, -16 lines 0 comments Download
M Source/web/WebDocument.cpp View 1 3 chunks +10 lines, -10 lines 0 comments Download
M Source/web/WebElement.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 4 chunks +13 lines, -13 lines 0 comments Download
M Source/web/WebNode.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/WebRange.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/web/tests/LocaleWinTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/StringImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Nils Barth (inactive)
Mechanical renaming, but changes 200+ files, so wanted to check before committing -- looks ok?
7 years, 1 month ago (2013-11-14 04:18:17 UTC) #1
haraken
On 2013/11/14 04:18:17, Nils Barth wrote: > Mechanical renaming, but changes 200+ files, > so ...
7 years, 1 month ago (2013-11-14 04:22:45 UTC) #2
Nils Barth (inactive)
On 2013/11/14 04:22:45, haraken wrote: > On 2013/11/14 04:18:17, Nils Barth wrote: > > Mechanical ...
7 years, 1 month ago (2013-11-14 05:00:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/72363002/1
7 years, 1 month ago (2013-11-14 05:00:16 UTC) #4
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
7 years, 1 month ago (2013-11-14 05:01:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/72363002/1
7 years, 1 month ago (2013-11-14 06:55:05 UTC) #6
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
7 years, 1 month ago (2013-11-14 06:56:07 UTC) #7
Nils Barth (inactive)
On 2013/11/14 06:56:07, I haz the power (commit-bot) wrote: > Failed to request the patch ...
7 years, 1 month ago (2013-11-15 01:11:35 UTC) #8
Nils Barth (inactive)
Committed patchset #2 manually as r162050 (presubmit successful).
7 years, 1 month ago (2013-11-15 01:21:14 UTC) #9
esprehn
On 2013/11/15 01:21:14, Nils Barth wrote: > Committed patchset #2 manually as r162050 (presubmit successful). ...
7 years, 1 month ago (2013-11-15 05:16:14 UTC) #10
esprehn
I'm going to roll this out, your patch contains Source/devtools/scripts/closure/compiler.jar even which definitely should not ...
7 years, 1 month ago (2013-11-15 05:19:32 UTC) #11
Nils Barth (inactive)
On 2013/11/15 05:19:32, esprehn wrote: > I'm going to roll this out, your patch contains ...
7 years, 1 month ago (2013-11-15 05:22:17 UTC) #12
apavlov
On 2013/11/15 05:19:32, esprehn wrote: > I'm going to roll this out, your patch contains ...
7 years, 1 month ago (2013-11-15 06:31:21 UTC) #13
Nils Barth (inactive)
On 2013/11/15 06:31:21, apavlov wrote: > Obviously, Source/devtools/front_end/Images/localStorage.png has been corrupted, > too Sorry about ...
7 years, 1 month ago (2013-11-15 06:41:06 UTC) #14
Nils Barth (inactive)
7 years, 1 month ago (2013-11-15 10:36:26 UTC) #15
Message was sent while issue was closed.
Postmortem:
(Sorry about the breakages; landing via CQ in followups,
so should catch anything I missed.)

Other that the obvious problem of not using the CQ,
looks like there were 3 real problems, and 2 aesthetic ones:
Changed 2 non C++ files (fixed by using '*.cpp' '*.h'):
.jar and .png

Changed one string literal ("es" = Spanish):
Source/core/rendering/RenderQuote.cpp
...causing this bug:
http://code.google.com/p/chromium/issues/detail?id=319645

Also 2 comments that should have been left as "es" (one for Spanish, one for
"Unix'es")

Checking for what contexts in which es appears, via:
git grep -w es -- '*.cpp' '*.h' |\
    sed -r 's/.*(.)\<es\>.*/\1/' |\
    sort | uniq -c
...shows ' ', (, !, and 1 & and 1 "
...so I believe RenderQuote.cpp is the only problem.

Checking comments manually:
git grep -w es -- '*.cpp' '*.h' | grep '//'
...yields the 2 comments above, which are not in core/.

So just omitting /"es"/ should be sufficient.

Powered by Google App Engine
This is Rietveld 408576698