Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 640603002: emitIAS for cvtt?.*2.* (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com, Derek Schuff
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : check scalar, and width #

Patch Set 3 : switch instead #

Patch Set 4 : use type func #

Total comments: 2

Patch Set 5 : move check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -78 lines) Patch
M src/IceInstX8632.h View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M src/IceInstX8632.cpp View 1 2 3 4 4 chunks +92 lines, -4 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download
M src/assembler_ia32.h View 2 chunks +19 lines, -11 lines 0 comments Download
M src/assembler_ia32.cpp View 1 2 3 2 chunks +43 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
6 years, 2 months ago (2014-10-08 16:05:22 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/640603002/diff/60001/src/IceInstX8632.cpp File src/IceInstX8632.cpp (right): https://codereview.chromium.org/640603002/diff/60001/src/IceInstX8632.cpp#newcode1483 src/IceInstX8632.cpp:1483: assert(isScalarFloatingType(DestTy)); Maybe also assert(SrcTy != DestTy)?
6 years, 2 months ago (2014-10-08 18:45:04 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/640603002/diff/60001/src/IceInstX8632.cpp File src/IceInstX8632.cpp (right): https://codereview.chromium.org/640603002/diff/60001/src/IceInstX8632.cpp#newcode1483 src/IceInstX8632.cpp:1483: assert(isScalarFloatingType(DestTy)); On 2014/10/08 18:45:03, stichnot wrote: > Maybe also ...
6 years, 2 months ago (2014-10-08 20:20:12 UTC) #4
jvoung (off chromium)
6 years, 2 months ago (2014-10-08 20:52:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
699bf02cdcd1e027f70944636017e01e0202a812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698