Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 640353003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
aandrey+blink_chromium.org, asanka, benjhayden+dwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, derat+watch_chromium.org, devtools-reviews_chromium.org, Greg Billock, nkostylev+watch_chromium.org, oshima+watch_chromium.org, paulirish+reviews_chromium.org, pfeldman, stevenjb+watch_chromium.org, Lei Zhang, tommycli, vandebo (ex-Chrome), vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/383ba8a52a3d703759644c51da41bd472f890ea3 Cr-Commit-Position: refs/heads/master@{#300016}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -89 lines) Patch
M chrome/browser/android/dev_tools_server.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_provider_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/apps/drive/drive_service_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/app_mode/fake_cws.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_service.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/power/power_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/dom_distiller/tab_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_test_file_activity_observer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/download/download_ui_controller_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/history/android/android_provider_backend.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/web_history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/profile_invalidation_provider_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/gcd_api_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_device_lister_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/privetv3_setup_flow_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
6 years, 2 months ago (2014-10-16 18:39:38 UTC) #2
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-16 21:01:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640353003/1
6 years, 2 months ago (2014-10-16 21:03:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640353003/20001
6 years, 2 months ago (2014-10-16 21:37:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 23:55:29 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 23:56:10 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/383ba8a52a3d703759644c51da41bd472f890ea3
Cr-Commit-Position: refs/heads/master@{#300016}

Powered by Google App Engine
This is Rietveld 408576698