chrome/browser/lifetime/browser_close_manager_browsertest.cc - Issue 640353003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/browser_close_manager_browsertest.cc

Issue 640353003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/lifetime/browser_close_manager_browsertest.cc

diff --git a/chrome/browser/lifetime/browser_close_manager_browsertest.cc b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

index 842103f4c3895360dca9d49534ba243eb44a3fb5..28e4d6e81685cb6633fc0d6c87f73ee1f1602cdb 100644

--- a/chrome/browser/lifetime/browser_close_manager_browsertest.cc

+++ b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

@@ -739,9 +739,8 @@ IN_PROC_BROWSER_TEST_P(BrowserCloseManagerWithDownloadsBrowserTest,

// Set up the fake delegate that forces the download to be malicious.

scoped_ptr<TestDownloadManagerDelegate> test_delegate(

new TestDownloadManagerDelegate(browser()->profile()));

- DownloadServiceFactory::GetForBrowserContext(browser()->profile())->

- SetDownloadManagerDelegateForTesting(

- test_delegate.PassAs<ChromeDownloadManagerDelegate>());

+ DownloadServiceFactory::GetForBrowserContext(browser()->profile())

+ ->SetDownloadManagerDelegateForTesting(test_delegate.Pass());

// Run a dangerous download, but the user doesn't make a decision.

// This .swf normally would be categorized as DANGEROUS_FILE, but

« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/local_discovery/gcd_api_flow_unittest.cc » ('j') | no next file with comments »