chrome/browser/download/download_ui_controller_unittest.cc - Issue 640353003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 640353003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_test_file_activity_observer.cc ('k') | chrome/browser/download/save_page_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_ui_controller_unittest.cc

diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc

index 84767173edbbc8f9e7acfbccb3185de12f8533ee..d540ca8da6b26ffebee121054b9a596a4630ffc9 100644

--- a/chrome/browser/download/download_ui_controller_unittest.cc

+++ b/chrome/browser/download/download_ui_controller_unittest.cc

@@ -175,9 +175,8 @@ void DownloadUIControllerTest::SetUp() {

scoped_ptr<HistoryAdapter> history_adapter(new HistoryAdapter);

history_adapter_ = history_adapter.get();

- scoped_ptr<DownloadHistory> download_history(new DownloadHistory(

- manager_.get(),

- history_adapter.PassAs<DownloadHistory::HistoryAdapter>()));

+ scoped_ptr<DownloadHistory> download_history(

+ new DownloadHistory(manager_.get(), history_adapter.Pass()));

ASSERT_TRUE(download_history_manager_observer_);

EXPECT_CALL(*manager_, AddObserver(_))