Credential Manager: Pass the correct credential type to the embedder.

Credential Manager: Pass the correct credential type to the embedder.

Currently, we're passing WebCredential objects; we ought to pass
WebLocalCredential or WebFederatedCredential objects. This patch adds
a '::create' method to WebCredential which constructs the proper type,
given a PlatformCredential, and teaches PlatformCredential to talk about
itself in order to make that type checking possible.

BUG=400674
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183523

[Mike West, 2014-10-09 13:15:45]

mkwst@chromium.org changed reviewers:
+ kenneth.r.christiansen@intel.com

[Mike West, 2014-10-09 13:15:45]

Kenneth: You wanted reviews, how about this one? :)

Jochen: If it looks sane, would you mind stamping platform/?

[kenneth.r.christiansen, 2014-10-09 13:34:03]

LGTM

https://codereview.chromium.org/640263002/diff/1/Source/platform/exported/Web...
File Source/platform/exported/WebCredential.cpp (right):

https://codereview.chromium.org/640263002/diff/1/Source/platform/exported/Web...
Source/platform/exported/WebCredential.cpp:24: return federated;
Wouldn´t it be better to add this in an if as well with a return and then add an
assert after if nothing was catched?

[Mike West, 2014-10-10 07:52:10]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-10-10 07:52:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640263002/20001

[commit-bot: I haz the power, 2014-10-10 09:29:54]

Committed patchset #2 (id:20001) as 183523