Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: public/platform/WebCredential.h

Issue 640263002: Credential Manager: Pass the correct credential type to the embedder. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Feedback. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/exported/WebLocalCredential.cpp ('k') | public/platform/WebFederatedCredential.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebCredential.h
diff --git a/public/platform/WebCredential.h b/public/platform/WebCredential.h
index 6ac6571fa3948cc81c0fbd3b868e698e0cf19e02..5d3dc4bad93a40ee8eb2d594804955f62519ef87 100644
--- a/public/platform/WebCredential.h
+++ b/public/platform/WebCredential.h
@@ -17,6 +17,7 @@ class PlatformCredential;
class WebCredential {
public:
BLINK_PLATFORM_EXPORT WebCredential(const WebString& id, const WebString& name, const WebURL& avatarURL);
+ BLINK_PLATFORM_EXPORT WebCredential(const WebCredential&);
virtual ~WebCredential() { reset(); }
BLINK_PLATFORM_EXPORT void assign(const WebCredential&);
@@ -26,16 +27,20 @@ public:
BLINK_PLATFORM_EXPORT WebString name() const;
BLINK_PLATFORM_EXPORT WebURL avatarURL() const;
- BLINK_PLATFORM_EXPORT virtual bool isLocalCredential() const { return false; }
- BLINK_PLATFORM_EXPORT virtual bool isFederatedCredential() const { return false; }
+ BLINK_PLATFORM_EXPORT bool isLocalCredential() const;
+ BLINK_PLATFORM_EXPORT bool isFederatedCredential() const;
#if INSIDE_BLINK
- BLINK_PLATFORM_EXPORT WebCredential(PlatformCredential*);
+ BLINK_PLATFORM_EXPORT static WebCredential create(PlatformCredential*);
BLINK_PLATFORM_EXPORT WebCredential& operator=(PlatformCredential*);
BLINK_PLATFORM_EXPORT PlatformCredential* platformCredential() const { return m_platformCredential.get(); }
#endif
protected:
+#if INSIDE_BLINK
+ BLINK_PLATFORM_EXPORT WebCredential(PlatformCredential*);
+#endif
+
WebPrivatePtr<PlatformCredential> m_platformCredential;
};
« no previous file with comments | « Source/platform/exported/WebLocalCredential.cpp ('k') | public/platform/WebFederatedCredential.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698