Source/platform/credentialmanager/PlatformCredential.h - Issue 640263002: Credential Manager: Pass the correct credential type to the embedder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/credentialmanager/PlatformCredential.h

Issue 640263002: Credential Manager: Pass the correct credential type to the embedder. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Feedback. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/credentialmanager/CredentialsContainer.cpp ('k') | Source/platform/credentialmanager/PlatformFederatedCredential.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/credentialmanager/PlatformCredential.h

diff --git a/Source/platform/credentialmanager/PlatformCredential.h b/Source/platform/credentialmanager/PlatformCredential.h

index a9baa5a33ad3a2b727b5987506bcf7b4e88d6eac..aee01b8559f683112d626ecc6139e9c424bb2b52 100644

--- a/Source/platform/credentialmanager/PlatformCredential.h

+++ b/Source/platform/credentialmanager/PlatformCredential.h

@@ -21,6 +21,9 @@ public:

const String& name() const { return m_name; }

const KURL& avatarURL() const { return m_avatarURL; }

+ virtual bool isLocal() { return false; }

+ virtual bool isFederated() { return false; }

virtual void trace(Visitor*) { }

protected: