Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 640143004: Remove context menus. (Closed)

Created:
6 years, 2 months ago by esprehn
Modified:
6 years, 2 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1844 lines) Patch
M sky/engine/core/core.gni View 4 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/events/Event.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/events/Event.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/events/EventTypeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/events/RelatedEvent.h View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/engine/core/events/RelatedEvent.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D sky/engine/core/events/RelatedEvent.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/engine/core/page/ContextMenuClient.h View 1 chunk +0 lines, -42 lines 0 comments Download
D sky/engine/core/page/ContextMenuController.h View 1 chunk +0 lines, -81 lines 0 comments Download
D sky/engine/core/page/ContextMenuController.cpp View 1 chunk +0 lines, -164 lines 0 comments Download
D sky/engine/core/page/ContextMenuProvider.h View 1 chunk +0 lines, -52 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 9 chunks +4 lines, -144 lines 0 comments Download
M sky/engine/core/page/Page.h View 4 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 5 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/TouchAdjustment.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/TouchAdjustment.cpp View 3 chunks +0 lines, -94 lines 0 comments Download
M sky/engine/core/testing/DummyPageHolder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/engine/platform/ContextMenu.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/platform/ContextMenu.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/platform/ContextMenuItem.h View 1 chunk +0 lines, -91 lines 0 comments Download
D sky/engine/platform/ContextMenuItem.cpp View 1 chunk +0 lines, -118 lines 0 comments Download
M sky/engine/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/public/web/WebContextMenuData.h View 1 chunk +0 lines, -185 lines 0 comments Download
M sky/engine/public/web/WebFrameClient.h View 2 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/public/web/WebInputEvent.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/public/web/WebView.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/web/ContextMenuClientImpl.h View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/engine/web/ContextMenuClientImpl.cpp View 1 chunk +0 lines, -373 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 8 chunks +0 lines, -23 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 10 chunks +0 lines, -126 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
lgtm https://codereview.chromium.org/640143004/diff/1/sky/engine/web/WebViewImpl.cpp File sky/engine/web/WebViewImpl.cpp (left): https://codereview.chromium.org/640143004/diff/1/sky/engine/web/WebViewImpl.cpp#oldcode186 sky/engine/web/WebViewImpl.cpp:186: , m_recreatingGraphicsContext(false) wat
6 years, 2 months ago (2014-10-24 00:02:36 UTC) #1
esprehn
6 years, 2 months ago (2014-10-24 00:10:11 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
01c3c79c9c85c079b43a25b17eac5de7dd0d1ffe.

Powered by Google App Engine
This is Rietveld 408576698