Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 639863006: Revert of Convert first letter into a pseudo element. (Closed)

Created:
6 years, 2 months ago by dsinclair
Modified:
6 years, 2 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-rendering, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, jchaffraix+rendering, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yosin_UTC9, yurys+blink_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert of Convert first letter into a pseudo element. (patchset #49 id:1570001 of https://codereview.chromium.org/571603003/) Reason for revert: Causing clusterfuzz regressions. Original issue's description: > Convert first letter into a pseudo element. > > Currently, first letter renderers are created and destroyed through the updateFirstLetters() call in > RenderBlock. This has, historically, been problematic as we may miss places where the call > was required, leading to accessing invalid memory. > > This CL converts the first letter code to use a PseudoElement for the first-letter instead of > creating classes during layout. > > With the PseudoElement implementation the two tests which are currently in > LayoutTests/fast/css/first-letter-removed-added.html work as expected. > > BUG=391288 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183913 TBR=jchaffraix@chromium.org,eseidel@chromium.org,esprehn@chromium.org,leviw@chromium.org,pdr@chromium.org BUG=391288 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184113

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix merge #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -678 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/dynamic-class-pseudo-elements.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/dynamic-class-pseudo-elements-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/css/first-letter.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/fast/css/first-letter-removed-added.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/first-letter-removed-added-expected.txt View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 4 chunks +3 lines, -16 lines 0 comments Download
M Source/core/dom/Element.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 7 chunks +1 line, -45 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 1 5 chunks +1 line, -11 lines 0 comments Download
M Source/core/dom/ElementRareData.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
D Source/core/dom/FirstLetterPseudoElement.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/dom/FirstLetterPseudoElement.cpp View 1 1 chunk +0 lines, -295 lines 0 comments Download
M Source/core/dom/Node.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 1 3 chunks +8 lines, -12 lines 0 comments Download
M Source/core/dom/PseudoElement.cpp View 1 5 chunks +4 lines, -11 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.h View 1 2 chunks +19 lines, -4 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 1 5 chunks +5 lines, -35 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 4 chunks +31 lines, -40 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 1 chunk +10 lines, -16 lines 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 7 chunks +12 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 3 chunks +247 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 3 chunks +28 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.cpp View 1 1 chunk +7 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTextFragment.h View 1 2 4 chunks +11 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderTextFragment.cpp View 1 5 chunks +66 lines, -51 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
dsinclair
Created Revert of Convert first letter into a pseudo element.
6 years, 2 months ago (2014-10-21 16:49:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639863006/1
6 years, 2 months ago (2014-10-21 16:50:36 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-21 16:51:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639863006/300001
6 years, 2 months ago (2014-10-21 17:01:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/14334)
6 years, 2 months ago (2014-10-21 17:25:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639863006/20006
6 years, 2 months ago (2014-10-21 17:42:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639863006/320001
6 years, 2 months ago (2014-10-21 18:50:18 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 20:00:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:320001) as 184113

Powered by Google App Engine
This is Rietveld 408576698